* Re: [PATCH v2 3/3] ARM: dts: r8a7742-iwg21d-q7: Enable SD2 LED indication
[not found] ` <CA+V-a8tEtQwfz=NstFdBXdJiSy4-QJDoT5HjOh1kgUbuFpgs4g@mail.gmail.com>
@ 2020-10-09 17:36 ` Pavel Machek
0 siblings, 0 replies; only message in thread
From: Pavel Machek @ 2020-10-09 17:36 UTC (permalink / raw)
To: Lad, Prabhakar, linux-leds, dmurphy
Cc: Lad Prabhakar, Geert Uytterhoeven, Magnus Damm, Rob Herring,
Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML,
Biju Das
[-- Attachment #1: Type: text/plain, Size: 827 bytes --]
Hi!
> Thank you for the review.
Note I'm LED maintainer.
> > > + leds {
> > > + compatible = "gpio-leds";
> > > +
> > > + sdhi2_led {
> > > + label = "sdio-led";
> >
> > This should use appropriate label... probably mmc1:green:activity.
> >
> $ grep -nr mmc | grep -i activity
> $ grep -nr sd | grep -i activity
>
> Results in 0 outputs in dts folder.
Well, so does
grep -ri label.*sdio-led arch/arm*
:-). Feel free to suggest other name following documentation in
Documentation/leds/leds-class.rst .
(And yes, we have lot of work to get this to some kind of consistent
state).
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-10-09 17:37 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200907155541.2011-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
[not found] ` <20200907155541.2011-4-prabhakar.mahadev-lad.rj@bp.renesas.com>
[not found] ` <20201009073349.GD10335@amd>
[not found] ` <CA+V-a8tEtQwfz=NstFdBXdJiSy4-QJDoT5HjOh1kgUbuFpgs4g@mail.gmail.com>
2020-10-09 17:36 ` [PATCH v2 3/3] ARM: dts: r8a7742-iwg21d-q7: Enable SD2 LED indication Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).