From: Pavel Machek <pavel@ucw.cz>
To: Vadim Pasternak <vadimp@nvidia.com>
Cc: Marek Behun <marek.behun@nic.cz>,
"jacek.anaszewski@gmail.com" <jacek.anaszewski@gmail.com>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>
Subject: Re: [PATCH led-next 1/1] leds: mlxreg: Allow multi-instantiation of same name LED for modular systems
Date: Wed, 25 Nov 2020 12:20:13 +0100 [thread overview]
Message-ID: <20201125112013.GC29328@amd> (raw)
In-Reply-To: <DM6PR12MB3898258991C6F8C0044B9BBAAF0B0@DM6PR12MB3898.namprd12.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 2103 bytes --]
Hi!
> > And yes, if you have some kind of device with a status LED, then you can put
> > that into the first card. For example sda::status would be accetpable. But
> > cardXX is way too generic.
> >
> > Perhaps you can explain what "card" is in this context? What is its main
> > function?
>
> I provide support for new modular systems which could be equipped with the
> different types of replaceable line cards and management board.
> The first type of line card is 16x100GbE QSFP28 Ethernet ports.
> It equipped with Lattice CPLD device aimed for system and ASIC control, Nvidia FPGA,
> Nvidia gearboxes (PHYs).
>
> After that we'll have other line cards: 8x200Gbe QSFP28 Eth ports, 4x400Gbe Eth QSFP-DD,
> smart cards equipped with Nvidia ARM CPU for offloading and for fast access to the storage
> (EBoF).
>
> For this modular system CPLDs are connected through I2C bus and LED driver will work
> over I2C. On main plane CPLD is connected through LPC, and LED driver works over LPC.
>
> Card is common name. But I'd like to avoid some more specific names.
>
> For example, we have huge InfiniBand modular systems with 800 of IB 200G and 400G
> ports, which I didn't have yet in upstream. Those system have also replaceable line cards
> (so called leaves) and replaceable fabric cards (so called spines).
> If I'll give name 'card<bus#>, it will be good also for those systems.
> If I'll give more specific name, it'll be not so good name for
> fabric cards.
Ok, I guess card<something> is best suggestion so far. If it is really
status for specific PCI card, then that's the right way to name it.
Maybe "pciecard<>" would be even better.
Plus we really should have documentation somewhere so that next
person trying to name a LED on a card ends up with same answer.
> I can use name 'fru' instead of 'card' which is standard name and stands for
> 'Filed Replicable Unit'. Such name will be good for line cards, for fabric cards,
> for power units, FANs etcetera.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2020-11-25 11:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 16:58 [PATCH led-next 1/1] leds: mlxreg: Allow multi-instantiation of same name LED for modular systems Vadim Pasternak
2020-10-06 23:15 ` Marek Behun
2020-10-07 6:07 ` Vadim Pasternak
2020-10-07 12:17 ` Marek Behun
2020-10-07 11:31 ` Pavel Machek
2020-10-07 12:20 ` Marek Behun
2020-10-08 6:16 ` Vadim Pasternak
2020-10-08 7:56 ` Pavel Machek
2020-10-08 8:47 ` Vadim Pasternak
2020-10-08 8:55 ` Marek Behun
2020-10-08 9:30 ` Vadim Pasternak
2020-10-08 10:05 ` Pavel Machek
2020-10-08 10:32 ` Vadim Pasternak
2020-11-25 11:20 ` Pavel Machek [this message]
2020-11-25 12:01 ` Vadim Pasternak
2020-12-30 18:48 ` Pavel Machek
2020-10-08 10:32 ` Marek Behun
2020-10-12 10:14 ` Vadim Pasternak
2020-10-21 8:33 ` Pavel Machek
2020-10-21 12:29 ` Vadim Pasternak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201125112013.GC29328@amd \
--to=pavel@ucw.cz \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=marek.behun@nic.cz \
--cc=vadimp@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).