Re: [PATCH led-next 1/1] leds: mlxreg: Allow multi-instantiation of same name LED for modular systems

[Pavel Machek <pavel@ucw.cz>]

[-- Attachment #1: Type: text/plain, Size: 2581 bytes --]

Hi!

> > > > And yes, if you have some kind of device with a status LED, then you
> > > > can put that into the first card. For example sda::status would be
> > > > accetpable. But cardXX is way too generic.
> > > >
> > > > Perhaps you can explain what "card" is in this context? What is its
> > > > main function?
> > >
> > > I provide support for new modular systems which could be equipped with
> > > the different types of replaceable line cards and management board.
> > > The first type of line card is 16x100GbE QSFP28 Ethernet ports.
> > > It equipped with Lattice CPLD device aimed for system and ASIC
> > > control, Nvidia FPGA, Nvidia gearboxes (PHYs).
> > >
> > > After that we'll have other line cards: 8x200Gbe QSFP28 Eth ports,
> > > 4x400Gbe Eth QSFP-DD, smart cards equipped with Nvidia ARM CPU for
> > > offloading and for fast access to the storage (EBoF).
> > >
> > > For this modular system CPLDs are connected through I2C bus and LED
> > > driver will work over I2C. On main plane CPLD is connected through LPC, and
> > LED driver works over LPC.
> > >
> > > Card is common name. But I'd like to avoid some more specific names.
> > >
> > > For example, we have huge InfiniBand modular systems with 800 of IB
> > > 200G and 400G ports, which I didn't have yet in upstream. Those system
> > > have also replaceable line cards (so called leaves) and replaceable fabric
> > cards (so called spines).
> > > If I'll give name 'card<bus#>, it will be good also for those systems.
> > > If I'll give more specific name, it'll be not so good name for
> >  > fabric cards.
> > 
> > Ok, I guess card<something> is best suggestion so far. If it is really status for
> > specific PCI card, then that's the right way to name it.
> > 
> > Maybe "pciecard<>" would be even better.
> 
> Hi Pavel,
> 
> Thank you for reply.
> 
> I'd like to avoid 'pci' in name.
> Line card can be connected to the different kinds of fabric. It could be for example
> InfiniBand or NVlink connectivity.
> 
> Also LED itself is accessed through I2C bus.
> 
> If you are OK with card<something>, where something in this case is I2C bus number,
> I'll send v2 patch with this change.

I'd prefer to have something kind of unique. Not every pcie card has
i2c bus on it. If card is on pcie it would be best to name it as it is
common for pcie. InfiniBand would be named according to ib
conventions, etc...

If that is impossible, I guess we can live with card<something> but...

									Pavel
-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]