From: Marek Behun <marek.behun@nic.cz>
To: Hermes Zhang <Hermes.Zhang@axis.com>
Cc: "pavel@ucw.cz" <pavel@ucw.cz>, "dmurphy@ti.com" <dmurphy@ti.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lkml@axis.com" <lkml@axis.com>, kernel <kernel@axis.com>
Subject: Re: [PATCH 1/2] leds: leds-multi-gpio: Add multiple GPIOs LED driver
Date: Thu, 25 Mar 2021 13:26:47 +0100 [thread overview]
Message-ID: <20210325132647.3004fd73@thinkpad> (raw)
In-Reply-To: <7ea3f7e6ea7a464fa4bb59b94857a755@XBOX01.axis.com>
On Thu, 25 Mar 2021 06:04:43 +0000
Hermes Zhang <Hermes.Zhang@axis.com> wrote:
> > LED_FULL / LED_OFF are deprecated, don't use them.
>
> Then could I use just 0 (instead LED_OFF) and led_cdev->max_brightness
>
> (instead of LED_FULL) here? The idea here is map the states defined in dts
>
> to the full brightness range.
Yes, you can and should use 0 insted of LED_OFF.
> > + priv->cdev.max_brightness = LED_FULL;
> > ???? max_brightness is not 255 (= LED_FULL). max_brightness must be
> > derived from the led-states property.
>
> Yeah, I will fix this. the max-brightness should for the whole LED,
> right? So
>
> it will at same level with led-states.
max_brightness should be (the number of states - 1). I.e. if you have 4
gpios and the LED supports full 2^4 = 16 states, max brightness should
be 15.
Marek
next prev parent reply other threads:[~2021-03-25 12:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 7:56 [PATCH 0/2] New multiple GPIOs LED driver Hermes Zhang
2021-03-24 7:56 ` [PATCH 1/2] leds: leds-multi-gpio: Add " Hermes Zhang
2021-03-24 10:34 ` Marek Behun
2021-03-24 10:40 ` Pavel Machek
2021-03-24 10:42 ` Pavel Machek
2021-03-25 6:04 ` Hermes Zhang
2021-03-25 12:26 ` Marek Behun [this message]
2021-03-24 10:41 ` Pavel Machek
2021-03-24 7:56 ` [PATCH 2/2] dt-binding: leds: Document leds-multi-gpio bindings Hermes Zhang
2021-03-24 10:40 ` Marek Behun
2021-03-25 5:27 ` Vesa Jääskeläinen
2021-03-25 18:41 ` Pavel Machek
2021-03-28 20:46 ` Vesa Jääskeläinen
2021-03-24 10:42 ` [PATCH 0/2] New multiple GPIOs LED driver Marek Behun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210325132647.3004fd73@thinkpad \
--to=marek.behun@nic.cz \
--cc=Hermes.Zhang@axis.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=lkml@axis.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).