From: Pavel Machek <pavel@ucw.cz>
To: "Marek Behún" <kabel@kernel.org>
Cc: andrew@lunn.ch, Heiner Kallweit <hkallweit1@gmail.com>,
Michael Walle <michael@walle.cc>,
anthony.l.nguyen@intel.com, bigeasy@linutronix.de,
davem@davemloft.net, dvorax.fuxbrumer@linux.intel.com,
f.fainelli@gmail.com, jacek.anaszewski@gmail.com,
kuba@kernel.org, kurt@linutronix.de, linux-leds@vger.kernel.org,
netdev@vger.kernel.org, sasha.neftin@intel.com,
vinicius.gomes@intel.com, vitaly.lifshits@intel.com
Subject: Re: [PATCH net-next 5/5] igc: Export LEDs
Date: Thu, 26 Aug 2021 14:45:11 +0200 [thread overview]
Message-ID: <20210826124511.GA20480@duo.ucw.cz> (raw)
In-Reply-To: <20210825172613.71b62113@dellmb>
[-- Attachment #1: Type: text/plain, Size: 1588 bytes --]
Hi!
> > > > > Pavel, one point of the discussion is that in this case the LED
> > > > > is controlled by MAC, not PHY. So the question is whether we
> > > > > want to do "ethmacN" (in addition to "ethphyN").
> > > >
> > > > Sorry, I missed that. I guess that yes, ethmacX is okay, too.
> > > >
> > > > Even better would be to find common term that could be used for
> > > > both ethmacN and ethphyN and just use that. (Except that we want
> > > > to avoid ethX). Maybe "ethportX" would be suitable?
> > >
> > > See
> > > https://lore.kernel.org/linux-leds/YQAlPrF2uu3Gr+0d@lunn.ch/
> > > and
> > > https://lore.kernel.org/linux-leds/20210727172828.1529c764@thinkpad/
> > >
> >
> > Ok, I guess I'd preffer all LEDs corresponding to one port to be
> > grouped, but that may be hard to do.
>
> Hi Pavel (and Andrew),
>
> The thing is that normally we are creating LED classdevs when the
> parent device is probed. In this case when the PHY is probed. But we
> will know the corresponding MAC only once the PHY is attached to it's
> network interface.
>
> Also, a PHY may be theoretically attached to multiple different
> interfaces during it's lifetime. I guess there isn't many boards
> currently that have such a configuration wired (maybe none), but
> kernel's API is prepared for this.
>
> So we really can't group them under one parent device, unless:
Ok, I guess my proposal is just too complex to implement. Let's go
with "ethmacN" + "ethphyN".
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2021-08-26 12:45 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210716212427.821834-1-anthony.l.nguyen@intel.com>
[not found] ` <20210716212427.821834-6-anthony.l.nguyen@intel.com>
[not found] ` <f705bcd6-c55c-0b07-612f-38348d85bbee@gmail.com>
[not found] ` <YPTKB0HGEtsydf9/@lunn.ch>
2021-07-20 15:00 ` [PATCH net-next 5/5] igc: Export LEDs Heiner Kallweit
2021-07-20 15:42 ` Andrew Lunn
2021-07-20 20:29 ` Heiner Kallweit
2021-07-21 14:35 ` Andrew Lunn
2021-07-21 16:02 ` Heiner Kallweit
2021-07-21 18:23 ` Pavel Machek
2021-07-21 18:25 ` Pavel Machek
2021-07-21 18:45 ` Marek Behún
2021-07-21 19:50 ` Andrew Lunn
2021-07-21 20:07 ` Marek Behún
2021-07-21 20:54 ` Andrew Lunn
2021-07-21 21:31 ` Marek Behún
2021-07-21 22:45 ` Pavel Machek
2021-07-22 1:45 ` Andrew Lunn
2021-07-22 2:19 ` Marek Behún
2021-07-21 22:34 ` Pavel Machek
2021-07-22 3:52 ` Florian Fainelli
2021-07-26 17:42 ` Jacek Anaszewski
2021-07-26 18:44 ` Marek Behún
2021-07-26 20:59 ` Heiner Kallweit
2021-07-27 0:06 ` Marek Behún
2021-07-27 1:57 ` Andrew Lunn
2021-07-27 8:15 ` Michael Walle
2021-07-27 14:56 ` Marek Behún
2021-07-27 15:03 ` Michael Walle
2021-07-27 15:24 ` Andrew Lunn
2021-07-27 15:28 ` Marek Behún
2021-07-27 15:53 ` Michael Walle
2021-07-27 16:23 ` Andrew Lunn
2021-07-27 16:32 ` Marek Behún
2021-07-27 16:42 ` Andrew Lunn
2021-07-27 19:42 ` Michael Walle
2021-07-28 20:43 ` Heiner Kallweit
2021-07-29 6:39 ` Kurt Kanzenbach
2021-07-29 8:59 ` Marek Behún
2021-07-29 21:54 ` Heiner Kallweit
2021-08-10 17:29 ` Pavel Machek
2021-08-10 17:55 ` Marek Behún
2021-08-10 19:53 ` Pavel Machek
2021-08-10 20:53 ` Marek Behún
2021-08-17 19:02 ` Pavel Machek
2021-08-25 15:26 ` Marek Behún
2021-08-26 12:45 ` Pavel Machek [this message]
2021-08-10 20:46 ` Heiner Kallweit
2021-08-10 21:21 ` Andrew Lunn
2021-07-27 13:55 ` Marek Behún
2021-08-10 17:22 ` Documentation for naming LEDs was " Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210826124511.GA20480@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=dvorax.fuxbrumer@linux.intel.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=jacek.anaszewski@gmail.com \
--cc=kabel@kernel.org \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linux-leds@vger.kernel.org \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
--cc=sasha.neftin@intel.com \
--cc=vinicius.gomes@intel.com \
--cc=vitaly.lifshits@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).