From: Michael Walle <michael@walle.cc>
To: "Marek Behún" <kabel@kernel.org>
Cc: andrew@lunn.ch, anthony.l.nguyen@intel.com,
bigeasy@linutronix.de, davem@davemloft.net,
dvorax.fuxbrumer@linux.intel.com, f.fainelli@gmail.com,
hkallweit1@gmail.com, jacek.anaszewski@gmail.com,
kuba@kernel.org, kurt@linutronix.de, linux-leds@vger.kernel.org,
netdev@vger.kernel.org, pavel@ucw.cz, sasha.neftin@intel.com,
vinicius.gomes@intel.com, vitaly.lifshits@intel.com
Subject: Re: [PATCH net-next 5/5] igc: Export LEDs
Date: Tue, 27 Jul 2021 21:42:05 +0200 [thread overview]
Message-ID: <3dbe3a7869dd7021f71467a53b6ac7f4@walle.cc> (raw)
In-Reply-To: <20210727183213.73f34141@thinkpad>
Am 2021-07-27 18:32, schrieb Marek Behún:
> On Tue, 27 Jul 2021 17:53:58 +0200
> Michael Walle <michael@walle.cc> wrote:
>
>> > If we used the devicename as you are suggesting, then for the two LEDs
>> > the devicename part would be the same:
>> > ledA -> macA -> ethernet0
>> > ledB -> phyB -> ethernet0
>> > although they are clearly on different MACs.
>>
>> Why is that the case? Why can't both the MAC and the PHY request a
>> unique name from the same namespace?
>
> So all the network related devices should request a unique network
> relate device ID? Should also wireless PHY devices do this? WWAN
> modems?
> And all these should have the same template for devicename part withing
> /sys/class/leds? What should be the template for the devicename, if
> wireless PHYs and WWAN modems could also be part of this? It cannot be
> "ethernet" anymore.
I don't suggest using ethernet for everything. I just questioned
wether the distinction between ethmac and ethphy makes any sense from
a (human) user point of view; if the devicename part is visible to an
user at all.
-michael
next prev parent reply other threads:[~2021-07-27 19:42 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210716212427.821834-1-anthony.l.nguyen@intel.com>
[not found] ` <20210716212427.821834-6-anthony.l.nguyen@intel.com>
[not found] ` <f705bcd6-c55c-0b07-612f-38348d85bbee@gmail.com>
[not found] ` <YPTKB0HGEtsydf9/@lunn.ch>
2021-07-20 15:00 ` [PATCH net-next 5/5] igc: Export LEDs Heiner Kallweit
2021-07-20 15:42 ` Andrew Lunn
2021-07-20 20:29 ` Heiner Kallweit
2021-07-21 14:35 ` Andrew Lunn
2021-07-21 16:02 ` Heiner Kallweit
2021-07-21 18:23 ` Pavel Machek
2021-07-21 18:25 ` Pavel Machek
2021-07-21 18:45 ` Marek Behún
2021-07-21 19:50 ` Andrew Lunn
2021-07-21 20:07 ` Marek Behún
2021-07-21 20:54 ` Andrew Lunn
2021-07-21 21:31 ` Marek Behún
2021-07-21 22:45 ` Pavel Machek
2021-07-22 1:45 ` Andrew Lunn
2021-07-22 2:19 ` Marek Behún
2021-07-21 22:34 ` Pavel Machek
2021-07-22 3:52 ` Florian Fainelli
2021-07-26 17:42 ` Jacek Anaszewski
2021-07-26 18:44 ` Marek Behún
2021-07-26 20:59 ` Heiner Kallweit
2021-07-27 0:06 ` Marek Behún
2021-07-27 1:57 ` Andrew Lunn
2021-07-27 8:15 ` Michael Walle
2021-07-27 14:56 ` Marek Behún
2021-07-27 15:03 ` Michael Walle
2021-07-27 15:24 ` Andrew Lunn
2021-07-27 15:28 ` Marek Behún
2021-07-27 15:53 ` Michael Walle
2021-07-27 16:23 ` Andrew Lunn
2021-07-27 16:32 ` Marek Behún
2021-07-27 16:42 ` Andrew Lunn
2021-07-27 19:42 ` Michael Walle [this message]
2021-07-28 20:43 ` Heiner Kallweit
2021-07-29 6:39 ` Kurt Kanzenbach
2021-07-29 8:59 ` Marek Behún
2021-07-29 21:54 ` Heiner Kallweit
2021-08-10 17:29 ` Pavel Machek
2021-08-10 17:55 ` Marek Behún
2021-08-10 19:53 ` Pavel Machek
2021-08-10 20:53 ` Marek Behún
2021-08-17 19:02 ` Pavel Machek
2021-08-25 15:26 ` Marek Behún
2021-08-26 12:45 ` Pavel Machek
2021-08-10 20:46 ` Heiner Kallweit
2021-08-10 21:21 ` Andrew Lunn
2021-07-27 13:55 ` Marek Behún
2021-08-10 17:22 ` Documentation for naming LEDs was " Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3dbe3a7869dd7021f71467a53b6ac7f4@walle.cc \
--to=michael@walle.cc \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=dvorax.fuxbrumer@linux.intel.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=jacek.anaszewski@gmail.com \
--cc=kabel@kernel.org \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linux-leds@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=sasha.neftin@intel.com \
--cc=vinicius.gomes@intel.com \
--cc=vitaly.lifshits@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).