linux-leds.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: leds: Replace moonlight with indicator in mt6360 example
@ 2021-11-17  7:22 cy_huang
  2021-11-17 10:52 ` Gene Chen
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: cy_huang @ 2021-11-17  7:22 UTC (permalink / raw)
  To: pavel, robh+dt, matthias.bgg, gene.chen.richtek
  Cc: linux-leds, devicetree, linux-arm-kernel, linux-mediatek,
	linux-kernel, gene_chen, wilma.wu, benjamin.chao, ChiYuan Huang

From: ChiYuan Huang <cy_huang@richtek.com>

Replace moonlight with indicator in mt6360 example to prevent the below
build error:

Error: Documentation/devicetree/bindings/leds/leds-mt6360.example.dts:114.24-25
syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:385:
Documentation/devicetree/bindings/leds/leds-mt6360.example.dt.yaml]
Error 1

Link: https://lore.kernel.org/lkml/CAL_JsqJRMVE163LaHTbtFARc4f_qg33bfQx+sD3ukce_xQF+gA@mail.gmail.com/
Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
---
Hi, Gene:

I saw you have removed LED_FUNCTION_MOONLIGHT in v14.
But you may forget to remove it from the binding example.

Please help to review this change.
---
 Documentation/devicetree/bindings/leds/leds-mt6360.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/leds/leds-mt6360.yaml b/Documentation/devicetree/bindings/leds/leds-mt6360.yaml
index 2353155..b2fe6eb 100644
--- a/Documentation/devicetree/bindings/leds/leds-mt6360.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-mt6360.yaml
@@ -133,7 +133,7 @@ examples:
      };
      led@3 {
        reg = <3>;
-       function = LED_FUNCTION_MOONLIGHT;
+       function = LED_FUNCTION_INDICATOR;
        color = <LED_COLOR_ID_WHITE>;
        led-max-microamp = <150000>;
      };
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: leds: Replace moonlight with indicator in mt6360 example
  2021-11-17  7:22 [PATCH] dt-bindings: leds: Replace moonlight with indicator in mt6360 example cy_huang
@ 2021-11-17 10:52 ` Gene Chen
  2021-11-18 14:38 ` Rob Herring
  2021-11-18 19:47 ` Pavel Machek
  2 siblings, 0 replies; 4+ messages in thread
From: Gene Chen @ 2021-11-17 10:52 UTC (permalink / raw)
  To: cy_huang
  Cc: Pavel Machek, Rob Herring, Matthias Brugger, Linux LED Subsystem,
	devicetree, linux-arm Mailing List,
	moderated list:ARM/Mediatek SoC support,
	Linux Kernel Mailing List, Gene Chen, wilma.wu, benjamin.chao,
	ChiYuan Huang

cy_huang <u0084500@gmail.com> 於 2021年11月17日 週三 下午3:22寫道:
>
> From: ChiYuan Huang <cy_huang@richtek.com>
>
> Replace moonlight with indicator in mt6360 example to prevent the below
> build error:
>
> Error: Documentation/devicetree/bindings/leds/leds-mt6360.example.dts:114.24-25
> syntax error
> FATAL ERROR: Unable to parse input tree
> make[1]: *** [scripts/Makefile.lib:385:
> Documentation/devicetree/bindings/leds/leds-mt6360.example.dt.yaml]
> Error 1
>
> Link: https://lore.kernel.org/lkml/CAL_JsqJRMVE163LaHTbtFARc4f_qg33bfQx+sD3ukce_xQF+gA@mail.gmail.com/
> Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> ---
> Hi, Gene:
>
> I saw you have removed LED_FUNCTION_MOONLIGHT in v14.
> But you may forget to remove it from the binding example.
>
> Please help to review this change.
> ---
>  Documentation/devicetree/bindings/leds/leds-mt6360.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-mt6360.yaml b/Documentation/devicetree/bindings/leds/leds-mt6360.yaml
> index 2353155..b2fe6eb 100644
> --- a/Documentation/devicetree/bindings/leds/leds-mt6360.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-mt6360.yaml
> @@ -133,7 +133,7 @@ examples:
>       };
>       led@3 {
>         reg = <3>;
> -       function = LED_FUNCTION_MOONLIGHT;
> +       function = LED_FUNCTION_INDICATOR;
>         color = <LED_COLOR_ID_WHITE>;
>         led-max-microamp = <150000>;
>       };
> --
> 2.7.4
>

Reviewed-by: Gene Chen <gene_chen@richtek.com>
Thanks

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: leds: Replace moonlight with indicator in mt6360 example
  2021-11-17  7:22 [PATCH] dt-bindings: leds: Replace moonlight with indicator in mt6360 example cy_huang
  2021-11-17 10:52 ` Gene Chen
@ 2021-11-18 14:38 ` Rob Herring
  2021-11-18 19:47 ` Pavel Machek
  2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2021-11-18 14:38 UTC (permalink / raw)
  To: cy_huang, Pavel Machek
  Cc: Matthias Brugger, Gene Chen, Linux LED Subsystem, devicetree,
	linux-arm-kernel, moderated list:ARM/Mediatek SoC support,
	linux-kernel, Gene Chen, wilma.wu, benjamin.chao, ChiYuan Huang

On Wed, Nov 17, 2021 at 1:22 AM cy_huang <u0084500@gmail.com> wrote:
>
> From: ChiYuan Huang <cy_huang@richtek.com>
>
> Replace moonlight with indicator in mt6360 example to prevent the below
> build error:
>
> Error: Documentation/devicetree/bindings/leds/leds-mt6360.example.dts:114.24-25
> syntax error
> FATAL ERROR: Unable to parse input tree
> make[1]: *** [scripts/Makefile.lib:385:
> Documentation/devicetree/bindings/leds/leds-mt6360.example.dt.yaml]
> Error 1
>
> Link: https://lore.kernel.org/lkml/CAL_JsqJRMVE163LaHTbtFARc4f_qg33bfQx+sD3ukce_xQF+gA@mail.gmail.com/
> Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> ---
> Hi, Gene:
>
> I saw you have removed LED_FUNCTION_MOONLIGHT in v14.
> But you may forget to remove it from the binding example.
>
> Please help to review this change.
> ---
>  Documentation/devicetree/bindings/leds/leds-mt6360.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: leds: Replace moonlight with indicator in mt6360 example
  2021-11-17  7:22 [PATCH] dt-bindings: leds: Replace moonlight with indicator in mt6360 example cy_huang
  2021-11-17 10:52 ` Gene Chen
  2021-11-18 14:38 ` Rob Herring
@ 2021-11-18 19:47 ` Pavel Machek
  2 siblings, 0 replies; 4+ messages in thread
From: Pavel Machek @ 2021-11-18 19:47 UTC (permalink / raw)
  To: cy_huang
  Cc: robh+dt, matthias.bgg, gene.chen.richtek, linux-leds, devicetree,
	linux-arm-kernel, linux-mediatek, linux-kernel, gene_chen,
	wilma.wu, benjamin.chao, ChiYuan Huang

[-- Attachment #1: Type: text/plain, Size: 504 bytes --]

Hi!

> Replace moonlight with indicator in mt6360 example to prevent the below
> build error:
> 
> Error: Documentation/devicetree/bindings/leds/leds-mt6360.example.dts:114.24-25
> syntax error
> FATAL ERROR: Unable to parse input tree
> make[1]: *** [scripts/Makefile.lib:385:
> Documentation/devicetree/bindings/leds/leds-mt6360.example.dt.yaml]
> Error 1

Thanks, applied, hopefully it makes the checker happy.

Best regards,
							Pavel
-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-11-18 19:47 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-17  7:22 [PATCH] dt-bindings: leds: Replace moonlight with indicator in mt6360 example cy_huang
2021-11-17 10:52 ` Gene Chen
2021-11-18 14:38 ` Rob Herring
2021-11-18 19:47 ` Pavel Machek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).