[PATCH] leds: Make LEDS_TI_LMU_COMMON invisible

[PATCH] leds: Make LEDS_TI_LMU_COMMON invisible

[Geert Uytterhoeven]

Currently, LEDS_LM3697 and LEDS_LM36274 depend on LEDS_TI_LMU_COMMON,
which contains the common code to support TI LMU devices.  This means
the user is asked about the common code first, followed by the
individual drivers, if their dependencies are met.

Simplify this, and reduce the number of questions by making
LEDS_TI_LMU_COMMON invisible, and letting it be selected when needed.

Fixes: 3fce8e1eb9945c27 ("leds: TI LMU: Add common code for TI LMU devices")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Exposed by commit a61079efc8788858 ("leds: TI_LMU_COMMON: select REGMAP
instead of depending on it").
---
 drivers/leds/Kconfig | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index 717c3bd804058813..55733fd4b1fb3860 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -814,8 +814,7 @@ config LEDS_SPI_BYTE
 	  supported: Ubiquiti airCube ISP microcontroller based LED controller.
 
 config LEDS_TI_LMU_COMMON
-	tristate "LED driver for TI LMU"
-	depends on LEDS_CLASS
+	tristate "LED driver for TI LMU" if COMPILE_TEST
 	select REGMAP
 	help
 	  Say Y to enable the LED driver for TI LMU devices.
@@ -824,16 +823,16 @@ config LEDS_TI_LMU_COMMON
 
 config LEDS_LM3697
 	tristate "LED driver for LM3697"
-	depends on LEDS_TI_LMU_COMMON
-	depends on I2C && OF
+	depends on LEDS_CLASS && I2C && OF
+	select LEDS_TI_LMU_COMMON
 	help
 	  Say Y to enable the LM3697 LED driver for TI LMU devices.
 	  This supports the LED device LM3697.
 
 config LEDS_LM36274
 	tristate "LED driver for LM36274"
-	depends on LEDS_TI_LMU_COMMON
-	depends on MFD_TI_LMU
+	depends on LEDS_CLASS && MFD_TI_LMU
+	select LEDS_TI_LMU_COMMON
 	help
 	  Say Y to enable the LM36274 LED driver for TI LMU devices.
 	  This supports the LED device LM36274.
-- 
2.34.1

Re: [PATCH] leds: Make LEDS_TI_LMU_COMMON invisible

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 824 bytes --]

On Tue 2023-05-09 17:07:47, Geert Uytterhoeven wrote:
> Currently, LEDS_LM3697 and LEDS_LM36274 depend on LEDS_TI_LMU_COMMON,
> which contains the common code to support TI LMU devices.  This means
> the user is asked about the common code first, followed by the
> individual drivers, if their dependencies are met.
> 
> Simplify this, and reduce the number of questions by making
> LEDS_TI_LMU_COMMON invisible, and letting it be selected when needed.
> 
> Fixes: 3fce8e1eb9945c27 ("leds: TI LMU: Add common code for TI LMU
devices")

Lets not do fixes tag. This is not "serious enough" for stable.

> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Pavel Machek <pavel@ucw.cz>

Best regards,
							Pavel

-- 
People of Russia, stop Putin before his war on Ukraine escalates.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: [PATCH] leds: Make LEDS_TI_LMU_COMMON invisible

[Lee Jones]

On Tue, 09 May 2023, Geert Uytterhoeven wrote:

> Currently, LEDS_LM3697 and LEDS_LM36274 depend on LEDS_TI_LMU_COMMON,
> which contains the common code to support TI LMU devices.  This means
> the user is asked about the common code first, followed by the
> individual drivers, if their dependencies are met.
> 
> Simplify this, and reduce the number of questions by making
> LEDS_TI_LMU_COMMON invisible, and letting it be selected when needed.
> 
> Fixes: 3fce8e1eb9945c27 ("leds: TI LMU: Add common code for TI LMU devices")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Exposed by commit a61079efc8788858 ("leds: TI_LMU_COMMON: select REGMAP
> instead of depending on it").
> ---
>  drivers/leds/Kconfig | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)

Fixes: tag removed and applied, thanks.

-- 
Lee Jones [李琼斯]