From: Tom Rix <trix@redhat.com>
To: pavel@ucw.cz, lee@kernel.org
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
Tom Rix <trix@redhat.com>
Subject: [PATCH] leds: cht-wcove: set function cht_wc_leds_brightness_get storage-class-specifier to static
Date: Tue, 30 May 2023 19:47:48 -0400 [thread overview]
Message-ID: <20230530234748.3641630-1-trix@redhat.com> (raw)
smatch reports
drivers/leds/leds-cht-wcove.c:144:21: warning: symbol
'cht_wc_leds_brightness_get' was not declared. Should it be static?
This function is only used in its defining file, so it should be static.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/leds/leds-cht-wcove.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/leds/leds-cht-wcove.c b/drivers/leds/leds-cht-wcove.c
index 0cfebee98910..0a5c30e5ed5d 100644
--- a/drivers/leds/leds-cht-wcove.c
+++ b/drivers/leds/leds-cht-wcove.c
@@ -141,7 +141,7 @@ static int cht_wc_leds_brightness_set(struct led_classdev *cdev,
return ret;
}
-enum led_brightness cht_wc_leds_brightness_get(struct led_classdev *cdev)
+static enum led_brightness cht_wc_leds_brightness_get(struct led_classdev *cdev)
{
struct cht_wc_led *led = container_of(cdev, struct cht_wc_led, cdev);
unsigned int val;
--
2.27.0
next reply other threads:[~2023-05-30 23:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 23:47 Tom Rix [this message]
2023-06-08 14:57 ` [PATCH] leds: cht-wcove: set function cht_wc_leds_brightness_get storage-class-specifier to static Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230530234748.3641630-1-trix@redhat.com \
--to=trix@redhat.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).