From: Lee Jones <lee@kernel.org>
To: Tom Rix <trix@redhat.com>
Cc: pavel@ucw.cz, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: cht-wcove: set function cht_wc_leds_brightness_get storage-class-specifier to static
Date: Thu, 8 Jun 2023 15:57:05 +0100 [thread overview]
Message-ID: <20230608145705.GN1930705@google.com> (raw)
In-Reply-To: <20230530234748.3641630-1-trix@redhat.com>
On Tue, 30 May 2023, Tom Rix wrote:
> smatch reports
> drivers/leds/leds-cht-wcove.c:144:21: warning: symbol
> 'cht_wc_leds_brightness_get' was not declared. Should it be static?
>
> This function is only used in its defining file, so it should be static.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/leds/leds-cht-wcove.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Sorry, you were pipped to the post:
https://lore.kernel.org/r/20230525183317.129232-1-hdegoede@redhat.com
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2023-06-08 14:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 23:47 [PATCH] leds: cht-wcove: set function cht_wc_leds_brightness_get storage-class-specifier to static Tom Rix
2023-06-08 14:57 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230608145705.GN1930705@google.com \
--to=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).