* [RESEND PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible
2023-06-02 13:36 [RESEND PATCH 0/2] leds: sgm3140: Add richtek,rt5033-led compatible Raymond Hackley
@ 2023-06-02 13:38 ` Raymond Hackley
2023-06-04 10:43 ` Krzysztof Kozlowski
2023-06-08 12:46 ` Lee Jones
2023-06-02 13:38 ` [RESEND PATCH 2/2] leds: sgm3140: Add richtek,rt5033-led compatible Raymond Hackley
2023-06-03 8:25 ` [RESEND PATCH 0/2] " Luca Weiss
2 siblings, 2 replies; 7+ messages in thread
From: Raymond Hackley @ 2023-06-02 13:38 UTC (permalink / raw)
To: open list
Cc: Pavel Machek, Lee Jones, Rob Herring, Krzysztof Kozlowski,
Luca Weiss, open list : LED SUBSYSTEM,
open list : OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
~postmarketos/upstreaming
Add devicetree binding for Richtek RT5033 Flash LED charge pump used for
camera flash LEDs.
Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
---
Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
index 4d2ffe5fcfc7..37d2a93780ab 100644
--- a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
@@ -20,6 +20,7 @@ properties:
compatible:
enum:
- ocs,ocp8110
+ - richtek,rt5033-led
- sgmicro,sgm3140
enable-gpios:
--
2.30.2
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [RESEND PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible
2023-06-02 13:38 ` [RESEND PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible Raymond Hackley
@ 2023-06-04 10:43 ` Krzysztof Kozlowski
2023-06-21 17:56 ` Raymond Hackley
2023-06-08 12:46 ` Lee Jones
1 sibling, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-04 10:43 UTC (permalink / raw)
To: Raymond Hackley, open list
Cc: Pavel Machek, Lee Jones, Rob Herring, Krzysztof Kozlowski,
Luca Weiss, open list : LED SUBSYSTEM,
open list : OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
~postmarketos/upstreaming
On 02/06/2023 15:38, Raymond Hackley wrote:
> Add devicetree binding for Richtek RT5033 Flash LED charge pump used for
> camera flash LEDs.
What are the similarities? Same register interface? Same pins? It's not
obvious and your commit should clear explain this. It will be also
justification why you did not make devices compatible.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible
2023-06-04 10:43 ` Krzysztof Kozlowski
@ 2023-06-21 17:56 ` Raymond Hackley
0 siblings, 0 replies; 7+ messages in thread
From: Raymond Hackley @ 2023-06-21 17:56 UTC (permalink / raw)
To: krzysztof.kozlowski
Cc: devicetree, krzysztof.kozlowski+dt, lee, linux-kernel,
linux-leds, luca, pavel, raymondhackley, robh+dt,
~postmarketos/upstreaming
Hi Krzysztof,
On Sunday, June 4th, 2023 at 10:43 AM, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> On 02/06/2023 15:38, Raymond Hackley wrote:
>
> > Add devicetree binding for Richtek RT5033 Flash LED charge pump used for
> > camera flash LEDs.
>
>
> What are the similarities? Same register interface? Same pins? It's not
> obvious and your commit should clear explain this. It will be also
> justification why you did not make devices compatible.
>
There is a similar way to control with 2 GPIO pins, strobe and enable,
which is not described well in this patch set.
Regards,
Raymond
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible
2023-06-02 13:38 ` [RESEND PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible Raymond Hackley
2023-06-04 10:43 ` Krzysztof Kozlowski
@ 2023-06-08 12:46 ` Lee Jones
1 sibling, 0 replies; 7+ messages in thread
From: Lee Jones @ 2023-06-08 12:46 UTC (permalink / raw)
To: Raymond Hackley
Cc: open list, Pavel Machek, Rob Herring, Krzysztof Kozlowski,
Luca Weiss, open list : LED SUBSYSTEM,
open list : OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
~postmarketos/upstreaming
I've not seen this because Protonmail has encoded your mail.
On Fri, 02 Jun 2023, Raymond Hackley wrote:
> Add devicetree binding for Richtek RT5033 Flash LED charge pump used for
> camera flash LEDs.
>
> Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
> ---
> Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> index 4d2ffe5fcfc7..37d2a93780ab 100644
> --- a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> @@ -20,6 +20,7 @@ properties:
> compatible:
> enum:
> - ocs,ocp8110
> + - richtek,rt5033-led
> - sgmicro,sgm3140
>
> enable-gpios:
> --
> 2.30.2
>
>
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [RESEND PATCH 2/2] leds: sgm3140: Add richtek,rt5033-led compatible
2023-06-02 13:36 [RESEND PATCH 0/2] leds: sgm3140: Add richtek,rt5033-led compatible Raymond Hackley
2023-06-02 13:38 ` [RESEND PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible Raymond Hackley
@ 2023-06-02 13:38 ` Raymond Hackley
2023-06-03 8:25 ` [RESEND PATCH 0/2] " Luca Weiss
2 siblings, 0 replies; 7+ messages in thread
From: Raymond Hackley @ 2023-06-02 13:38 UTC (permalink / raw)
To: open list
Cc: Pavel Machek, Lee Jones, Rob Herring, Krzysztof Kozlowski,
Luca Weiss, open list : LED SUBSYSTEM,
open list : OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
~postmarketos/upstreaming
Richtek's rt5033-led has pin configurations similar to sgm3140.
Add it to the compatible list.
Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
---
drivers/leds/flash/leds-sgm3140.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/leds/flash/leds-sgm3140.c b/drivers/leds/flash/leds-sgm3140.c
index d3a30ad94ac4..d3f50dca5136 100644
--- a/drivers/leds/flash/leds-sgm3140.c
+++ b/drivers/leds/flash/leds-sgm3140.c
@@ -291,6 +291,7 @@ static int sgm3140_remove(struct platform_device *pdev)
static const struct of_device_id sgm3140_dt_match[] = {
{ .compatible = "ocs,ocp8110" },
+ { .compatible = "richtek,rt5033-led" },
{ .compatible = "sgmicro,sgm3140" },
{ /* sentinel */ }
};
--
2.30.2
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [RESEND PATCH 0/2] leds: sgm3140: Add richtek,rt5033-led compatible
2023-06-02 13:36 [RESEND PATCH 0/2] leds: sgm3140: Add richtek,rt5033-led compatible Raymond Hackley
2023-06-02 13:38 ` [RESEND PATCH 1/2] dt-bindings: leds: sgm3140: Document richtek,rt5033 compatible Raymond Hackley
2023-06-02 13:38 ` [RESEND PATCH 2/2] leds: sgm3140: Add richtek,rt5033-led compatible Raymond Hackley
@ 2023-06-03 8:25 ` Luca Weiss
2 siblings, 0 replies; 7+ messages in thread
From: Luca Weiss @ 2023-06-03 8:25 UTC (permalink / raw)
To: open list, Raymond Hackley
Cc: Pavel Machek, Lee Jones, Rob Herring, Krzysztof Kozlowski,
open list : LED SUBSYSTEM,
open list : OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
~postmarketos/upstreaming, Raymond Hackley
Hi Raymond,
On Freitag, 2. Juni 2023 15:36:16 CEST Raymond Hackley wrote:
> Richtek's rt5033-led has pin configurations similar to sgm3140.
> Add it to the compatible list.
please fix your email setup so that patches also sent to public mailing lists
don't get *encrypted*. This is completely pointless and just makes everything
more difficult.
Regards
Luca
^ permalink raw reply [flat|nested] 7+ messages in thread