* [PATCH] leds: simatic-ipc-leds-gpio: restore LEDS_CLASS dependency
@ 2023-06-23 15:22 Arnd Bergmann
2023-07-13 9:34 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2023-06-23 15:22 UTC (permalink / raw)
To: Pavel Machek, Lee Jones, Andy Shevchenko, Henning Schild
Cc: Arnd Bergmann, Hans de Goede, linux-leds, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
A recent rework accidentally lost the dependency on LEDS_CLASS, which
leads to a link error when LED support is disbled:
x86_64-linux-ld: drivers/leds/simple/simatic-ipc-leds.o: in function `simatic_ipc_leds_probe':
simatic-ipc-leds.c:(.text+0x10c): undefined reference to `devm_led_classdev_register_ext'
Add back the dependency that was there originally.
Fixes: a6c80bec3c935 ("leds: simatic-ipc-leds-gpio: Add GPIO version of Siemens driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/leds/simple/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/leds/simple/Kconfig b/drivers/leds/simple/Kconfig
index 44fa0f93cb3b3..02443e745ff3b 100644
--- a/drivers/leds/simple/Kconfig
+++ b/drivers/leds/simple/Kconfig
@@ -1,6 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only
config LEDS_SIEMENS_SIMATIC_IPC
tristate "LED driver for Siemens Simatic IPCs"
+ depends on LEDS_CLASS
depends on SIEMENS_SIMATIC_IPC
help
This option enables support for the LEDs of several Industrial PCs
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] leds: simatic-ipc-leds-gpio: restore LEDS_CLASS dependency
2023-06-23 15:22 [PATCH] leds: simatic-ipc-leds-gpio: restore LEDS_CLASS dependency Arnd Bergmann
@ 2023-07-13 9:34 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2023-07-13 9:34 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Pavel Machek, Andy Shevchenko, Henning Schild, Arnd Bergmann,
Hans de Goede, linux-leds, linux-kernel
On Fri, 23 Jun 2023, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> A recent rework accidentally lost the dependency on LEDS_CLASS, which
> leads to a link error when LED support is disbled:
>
> x86_64-linux-ld: drivers/leds/simple/simatic-ipc-leds.o: in function `simatic_ipc_leds_probe':
> simatic-ipc-leds.c:(.text+0x10c): undefined reference to `devm_led_classdev_register_ext'
>
> Add back the dependency that was there originally.
>
> Fixes: a6c80bec3c935 ("leds: simatic-ipc-leds-gpio: Add GPIO version of Siemens driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/leds/simple/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-13 9:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-23 15:22 [PATCH] leds: simatic-ipc-leds-gpio: restore LEDS_CLASS dependency Arnd Bergmann
2023-07-13 9:34 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).