* [PATCH] gpio: pca953x: Include the right header
@ 2019-08-08 13:20 Linus Walleij
2019-08-08 18:50 ` Jacek Anaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2019-08-08 13:20 UTC (permalink / raw)
To: Jacek Anaszewski, Pavel Machek, Dan Murphy; +Cc: linux-leds, Linus Walleij
This LED chip provides a GPIO driver, so include
<linux/gpio/driver.h> rather than the legacy header
<linux/gpio.h>.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/leds/leds-pca9532.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c
index 290871072d65..c7c7199e8ebd 100644
--- a/drivers/leds/leds-pca9532.c
+++ b/drivers/leds/leds-pca9532.c
@@ -16,7 +16,7 @@
#include <linux/mutex.h>
#include <linux/workqueue.h>
#include <linux/leds-pca9532.h>
-#include <linux/gpio.h>
+#include <linux/gpio/driver.h>
#include <linux/of.h>
#include <linux/of_device.h>
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: pca953x: Include the right header
2019-08-08 13:20 [PATCH] gpio: pca953x: Include the right header Linus Walleij
@ 2019-08-08 18:50 ` Jacek Anaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Jacek Anaszewski @ 2019-08-08 18:50 UTC (permalink / raw)
To: Linus Walleij, Pavel Machek, Dan Murphy; +Cc: linux-leds
Hi Linus,
Thank you for the patch.
On 8/8/19 3:20 PM, Linus Walleij wrote:
> This LED chip provides a GPIO driver, so include
> <linux/gpio/driver.h> rather than the legacy header
> <linux/gpio.h>.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/leds/leds-pca9532.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c
> index 290871072d65..c7c7199e8ebd 100644
> --- a/drivers/leds/leds-pca9532.c
> +++ b/drivers/leds/leds-pca9532.c
> @@ -16,7 +16,7 @@
> #include <linux/mutex.h>
> #include <linux/workqueue.h>
> #include <linux/leds-pca9532.h>
> -#include <linux/gpio.h>
> +#include <linux/gpio/driver.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
I've changed the patch title prefix to "leds: pca953x:" -
(this is for leds-pca9532.c driver) and applied.
--
Best regards,
Jacek Anaszewski
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-08 18:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-08 13:20 [PATCH] gpio: pca953x: Include the right header Linus Walleij
2019-08-08 18:50 ` Jacek Anaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).