From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Jean-Jacques Hiblot <jjhiblot@ti.com>,
pavel@ucw.cz, robh+dt@kernel.org, mark.rutland@arm.com,
lee.jones@linaro.org, daniel.thompson@linaro.org
Cc: dmurphy@ti.com, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
tomi.valkeinen@ti.com
Subject: Re: [PATCH v7 3/5] leds: Add managed API to get a LED from a device driver
Date: Tue, 24 Sep 2019 23:10:02 +0200 [thread overview]
Message-ID: <5b252fe0-8b9b-1f12-9915-4970f766d5d9@gmail.com> (raw)
In-Reply-To: <20190918145730.22805-4-jjhiblot@ti.com>
Jean,
On 9/18/19 4:57 PM, Jean-Jacques Hiblot wrote:
> If the LED is acquired by a consumer device with devm_led_get(), it is
> automatically released when the device is detached.
>
> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
> Acked-by: Pavel Machek <pavel@ucw.cz>
> ---
> drivers/leds/led-class.c | 51 ++++++++++++++++++++++++++++++++++++++++
> include/linux/leds.h | 2 ++
> 2 files changed, 53 insertions(+)
>
> diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
> index 2b8f20f94128..e11177d77b4c 100644
> --- a/drivers/leds/led-class.c
> +++ b/drivers/leds/led-class.c
> @@ -264,6 +264,57 @@ void led_put(struct led_classdev *led_cdev)
> }
> EXPORT_SYMBOL_GPL(led_put);
>
> +static void devm_led_release(struct device *dev, void *res)
> +{
> + struct led_classdev **p = res;
> +
> + led_put(*p);
> +}
> +
> +/**
> + * devm_led_get - Resource-managed request of a LED device
> + * @dev: LED consumer
> + * @idx: index of the LED to obtain in the consumer
> + *
> + * The device node of the device is parse to find the request LED device.
> + * The LED device returned from this function is automatically released
> + * on driver detach.
> + *
> + * NOTE: At the moment, it supports only device-tree based LED lookup
> + *
> + * @return a pointer to a LED device or ERR_PTR(errno) on failure.
> + */
> +struct led_classdev *__must_check devm_led_get(struct device *dev,
> + int index)
s/devm_led_get/devm_of_led_get/
> +{
> + struct led_classdev *led;
> + struct led_classdev **dr;
> +
> + if (!dev)
> + return ERR_PTR(-EINVAL);
> +
> + /* Not using device tree? */
> + if (!IS_ENABLED(CONFIG_OF) || !dev->of_node)
> + return ERR_PTR(-ENOTSUPP);
> +
> + led = of_led_get(dev->of_node, index);
> + if (IS_ERR(led))
> + return led;
> +
> + dr = devres_alloc(devm_led_release, sizeof(struct led_classdev *),
> + GFP_KERNEL);
> + if (!dr) {
> + led_put(led);
> + return ERR_PTR(-ENOMEM);
> + }
> +
> + *dr = led;
> + devres_add(dev, dr);
> +
> + return led;
> +}
> +EXPORT_SYMBOL_GPL(devm_led_get);
> +
> static int led_classdev_next_name(const char *init_name, char *name,
> size_t len)
> {
> diff --git a/include/linux/leds.h b/include/linux/leds.h
> index 6f7371bc7757..88bf2ceaabe6 100644
> --- a/include/linux/leds.h
> +++ b/include/linux/leds.h
> @@ -199,6 +199,8 @@ extern void led_classdev_resume(struct led_classdev *led_cdev);
>
> extern struct led_classdev *of_led_get(struct device_node *np, int index);
> extern void led_put(struct led_classdev *led_cdev);
> +struct led_classdev *__must_check devm_led_get(struct device *dev,
> + int index);
>
> /**
> * led_blink_set - set blinking with software fallback
>
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2019-09-24 21:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 14:57 [PATCH v7 0/5] Add a generic driver for LED-based backlight Jean-Jacques Hiblot
2019-09-18 14:57 ` [PATCH v7 1/5] leds: populate the device's of_node when possible Jean-Jacques Hiblot
2019-09-24 21:03 ` Jacek Anaszewski
2019-10-02 13:58 ` Jean-Jacques Hiblot
2019-10-02 19:47 ` Jacek Anaszewski
2019-09-18 14:57 ` [PATCH v7 2/5] leds: Add of_led_get() and led_put() Jean-Jacques Hiblot
2019-09-24 21:08 ` Jacek Anaszewski
2019-09-18 14:57 ` [PATCH v7 3/5] leds: Add managed API to get a LED from a device driver Jean-Jacques Hiblot
2019-09-24 21:10 ` Jacek Anaszewski [this message]
2019-09-18 14:57 ` [PATCH v7 4/5] dt-bindings: backlight: Add led-backlight binding Jean-Jacques Hiblot
2019-10-04 14:38 ` Lee Jones
2019-09-18 14:57 ` [PATCH v7 5/5] backlight: add led-backlight driver Jean-Jacques Hiblot
2019-10-04 14:39 ` Lee Jones
2019-10-04 15:49 ` Jean-Jacques Hiblot
2019-10-14 7:57 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b252fe0-8b9b-1f12-9915-4970f766d5d9@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=daniel.thompson@linaro.org \
--cc=dmurphy@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jjhiblot@ti.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).