From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Jean-Jacques Hiblot <jjhiblot@ti.com>,
pavel@ucw.cz, robh+dt@kernel.org, mark.rutland@arm.com,
lee.jones@linaro.org, daniel.thompson@linaro.org
Cc: dmurphy@ti.com, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
tomi.valkeinen@ti.com
Subject: Re: [PATCH v7 1/5] leds: populate the device's of_node when possible
Date: Wed, 2 Oct 2019 21:47:18 +0200 [thread overview]
Message-ID: <b7b3409b-97bd-79b4-a712-6c03c6eabd56@gmail.com> (raw)
In-Reply-To: <e9588e03-20d4-7e6d-e514-0b79dae12cce@ti.com>
Hi Jean,
On 10/2/19 3:58 PM, Jean-Jacques Hiblot wrote:
> Hi Jacek,
>
> On 24/09/2019 23:03, Jacek Anaszewski wrote:
>> Hi Jean,
>>
>> Thank you for rebasing the set
>>
>> On 9/18/19 4:57 PM, Jean-Jacques Hiblot wrote:
>>> If initialization data is available and its fwnode is actually a
>>> of_node,
>>> store this information in the led device's structure. This will allow
>>> the
>>> device to use or provide OF-based API such (devm_xxx).
>>>
>>> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
>>> ---
>>> drivers/leds/led-class.c | 5 ++++-
>>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
>>> index 647b1263c579..c2167b66b61f 100644
>>> --- a/drivers/leds/led-class.c
>>> +++ b/drivers/leds/led-class.c
>>> @@ -276,8 +276,11 @@ int led_classdev_register_ext(struct device
>>> *parent,
>>> mutex_unlock(&led_cdev->led_access);
>>> return PTR_ERR(led_cdev->dev);
>>> }
>>> - if (init_data && init_data->fwnode)
>>> + if (init_data && init_data->fwnode) {
>>> led_cdev->dev->fwnode = init_data->fwnode;
>>> + if (is_of_node(init_data->fwnode))
>>> + led_cdev->dev->of_node = to_of_node(init_data->fwnode);
>> It would be step backwards. You can do the conversion in the place of
>> use i.e. in devm_led_get().
>
> Could be done. But it would break another use case I have. I'm also
> working on the regulator support and for this one, of_node needs to be
> populated.
I thought that regulator core can do the conversion to of_node itself,
but this seems not to be the case.
> Is there a problem populating of_node if the LED is indeed described in
> the DT ?
No, if it is not possible to do it otherwise.
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2019-10-02 19:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 14:57 [PATCH v7 0/5] Add a generic driver for LED-based backlight Jean-Jacques Hiblot
2019-09-18 14:57 ` [PATCH v7 1/5] leds: populate the device's of_node when possible Jean-Jacques Hiblot
2019-09-24 21:03 ` Jacek Anaszewski
2019-10-02 13:58 ` Jean-Jacques Hiblot
2019-10-02 19:47 ` Jacek Anaszewski [this message]
2019-09-18 14:57 ` [PATCH v7 2/5] leds: Add of_led_get() and led_put() Jean-Jacques Hiblot
2019-09-24 21:08 ` Jacek Anaszewski
2019-09-18 14:57 ` [PATCH v7 3/5] leds: Add managed API to get a LED from a device driver Jean-Jacques Hiblot
2019-09-24 21:10 ` Jacek Anaszewski
2019-09-18 14:57 ` [PATCH v7 4/5] dt-bindings: backlight: Add led-backlight binding Jean-Jacques Hiblot
2019-10-04 14:38 ` Lee Jones
2019-09-18 14:57 ` [PATCH v7 5/5] backlight: add led-backlight driver Jean-Jacques Hiblot
2019-10-04 14:39 ` Lee Jones
2019-10-04 15:49 ` Jean-Jacques Hiblot
2019-10-14 7:57 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7b3409b-97bd-79b4-a712-6c03c6eabd56@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=daniel.thompson@linaro.org \
--cc=dmurphy@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jjhiblot@ti.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).