linux-leds.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Murphy <dmurphy@ti.com>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	Pavel Machek <pavel@ucw.cz>
Cc: <devicetree@vger.kernel.org>, <linux-leds@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v26 03/15] leds: multicolor: Introduce a multicolor class definition
Date: Tue, 9 Jun 2020 06:45:36 -0500	[thread overview]
Message-ID: <80bb24a5-fffb-73ef-e184-6664f47bcf24@ti.com> (raw)
In-Reply-To: <5bb77966-70d7-3331-1487-bb2af1b4b755@gmail.com>

Jacek

On 6/8/20 2:41 PM, Jacek Anaszewski wrote:
> Dan,
>
> On 6/8/20 4:34 PM, Dan Murphy wrote:
>> Jacek
>>
>> On 6/6/20 2:59 PM, Jacek Anaszewski wrote:
>>> Dan,
>>>
>>> On 6/6/20 6:39 PM, Dan Murphy wrote:
>>>> Pavek
>>>>
>>>> Thanks for the review
>>>>
>>>> On 6/6/20 10:53 AM, Pavel Machek wrote:
>>>>> Hi!
>>>>>
>>>>>> Introduce a multicolor class that groups colored LEDs
>>>>>> within a LED node.
>>>>>>
>>>>>> The multi color class groups monochrome LEDs and allows 
>>>>>> controlling two
>>>>>> aspects of the final combined color: hue and lightness. The 
>>>>>> former is
>>>>>> controlled via the intensity file and the latter is controlled
>>>>>> via brightness file.
>>>>>>
>>>>>> Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
>>>>>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>>>>>> diff --git a/Documentation/ABI/testing/sysfs-class-led-multicolor 
>>>>>> b/Documentation/ABI/testing/sysfs-class-led-multicolor
>>>>>> new file mode 100644
>>> [...]
>>>>>> --- a/MAINTAINERS
>>>>>> +++ b/MAINTAINERS
>>>>>> @@ -9533,6 +9533,14 @@ F: Documentation/devicetree/bindings/leds/
>>>>>>   F:    drivers/leds/
>>>>>>   F:    include/linux/leds.h
>>>>>> +LED MULTICOLOR FRAMEWORK
>>>>>> +M:    Dan Murphy <dmurphy@ti.com>
>>>>>> +L:    linux-leds@vger.kernel.org
>>>>> I'd like to be mentioned here, too. "M: Pavel Machek
>>>>> <pavel@ucw.cz>". And I'm not sure if I should be taking MAINTAINER
>>>>> file update through a LED tree. Should definitely go to separate
>>>>> patch.
>>>>
>>>> Oh definitely.  I thought it was implied that you and Jacek are 
>>>> both Maintainers as well.
>>>>
>>>> I will add you but will wait to see if Jacek wants to be added.
>>>
>>> Actually I don't think that we need to add this separate entry
>>> for LED multicolor class. This is still under LED subsystem,
>>> and I didn't add anything for LED class flash.
>>
>> We only need this because I am not a maintainer of the LED flash 
>> class or the LED class.
>>
>> But since I authored the code it only made sense to add me as a 
>> maintainer for this specific class.
>>
>> You are one of the maintainers of the LED subsystem and wrote the 
>> Flash class so your maintainer ship is implied and you will be CC'd 
>> for all patches.
>>
>> This will not be the case for the multi color class
>
> scripts/get_maintainer.pl returns yourself as well for LED drivers.
> But it's up to you.
>
I dropped it.

Dan


  reply	other threads:[~2020-06-09 11:45 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-04 12:04 [PATCH v26 00/15] Multicolor Framework v26 Dan Murphy
2020-06-04 12:04 ` [PATCH v26 01/15] dt: bindings: Add multicolor class dt bindings documention Dan Murphy
2020-06-04 22:40   ` Rob Herring
2020-06-05 12:42     ` Dan Murphy
2020-06-04 12:04 ` [PATCH v26 02/15] leds: Add multicolor ID to the color ID list Dan Murphy
2020-06-04 12:04 ` [PATCH v26 03/15] leds: multicolor: Introduce a multicolor class definition Dan Murphy
2020-06-06 15:53   ` Pavel Machek
2020-06-06 16:39     ` Dan Murphy
2020-06-06 19:59       ` Jacek Anaszewski
2020-06-08 14:34         ` Dan Murphy
2020-06-08 19:41           ` Jacek Anaszewski
2020-06-09 11:45             ` Dan Murphy [this message]
2020-06-04 12:04 ` [PATCH v26 04/15] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers Dan Murphy
2020-06-04 22:59   ` Rob Herring
2020-06-08 18:21     ` Dan Murphy
2020-06-04 12:04 ` [PATCH v26 05/15] leds: lp50xx: Add the LP50XX family of the RGB LED driver Dan Murphy
2020-06-04 12:04 ` [PATCH v26 06/15] dt-bindings: leds: Convert leds-lp55xx to yaml Dan Murphy
2020-06-04 23:04   ` Rob Herring
2020-06-05  0:08     ` Dan Murphy
2020-06-08 17:50       ` Rob Herring
2020-06-04 12:04 ` [PATCH v26 07/15] ARM: dts: n900: Add reg property to the LP5523 channel node Dan Murphy
2020-06-04 12:04 ` [PATCH v26 08/15] ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 " Dan Murphy
2020-06-04 12:04 ` [PATCH v26 09/15] ARM: dts: ste-href: Add reg property to the LP5521 channel nodes Dan Murphy
2020-06-04 12:04 ` [PATCH v26 10/15] leds: lp55xx: Convert LED class registration to devm_* Dan Murphy
2020-06-04 12:05 ` [PATCH v26 11/15] leds: lp55xx: Add multicolor framework support to lp55xx Dan Murphy
2020-06-04 12:05 ` [PATCH v26 12/15] leds: lp5523: Update the lp5523 code to add multicolor brightness function Dan Murphy
2020-06-04 12:05 ` [PATCH v26 13/15] leds: lp5521: Add multicolor framework multicolor brightness support Dan Murphy
2020-06-04 12:05 ` [PATCH v26 14/15] leds: lp55xx: Fix file permissions to use DEVICE_ATTR macros Dan Murphy
2020-06-04 12:05 ` [PATCH v26 15/15] leds: lp5523: Fix various formatting issues in the code Dan Murphy
2020-06-06 15:57 ` [PATCH v26 00/15] Multicolor Framework v26 Pavel Machek
2020-06-08 18:35   ` Dan Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=80bb24a5-fffb-73ef-e184-6664f47bcf24@ti.com \
    --to=dmurphy@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jacek.anaszewski@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).