Re: [PATCH v26 01/15] dt: bindings: Add multicolor class dt bindings documention

From: Dan Murphy <dmurphy@ti.com>
To: Rob Herring <robh@kernel.org>
Cc: <jacek.anaszewski@gmail.com>, <pavel@ucw.cz>,
	<devicetree@vger.kernel.org>, <linux-leds@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v26 01/15] dt: bindings: Add multicolor class dt bindings documention
Date: Fri, 5 Jun 2020 07:42:44 -0500	[thread overview]
Message-ID: <8b32231a-90d8-258e-d828-362af8cbfbb5@ti.com> (raw)
In-Reply-To: <20200604224026.GA4153787@bogus>

Rob

On 6/4/20 5:40 PM, Rob Herring wrote:
> On Thu, Jun 04, 2020 at 07:04:50AM -0500, Dan Murphy wrote:
>> Add DT bindings for the LEDs multicolor class framework.
>> Add multicolor ID to the color ID list for device tree bindings.
>>
>> CC: Rob Herring <robh@kernel.org>
>> Acked-by: Pavel Machek <pavel@ucw.cz>
>> Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> ---
>>   .../bindings/leds/leds-class-multicolor.yaml  | 39 +++++++++++++++++++
>>   include/dt-bindings/leds/common.h             |  3 +-
>>   2 files changed, 41 insertions(+), 1 deletion(-)
>>   create mode 100644 Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml
>> new file mode 100644
>> index 000000000000..6cab2a1405e1
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml
>> @@ -0,0 +1,39 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/leds/leds-class-multicolor.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Common properties for the multicolor LED class.
>> +
>> +maintainers:
>> +  - Dan Murphy <dmurphy@ti.com>
>> +
>> +description: |
>> +  Bindings for multi color LEDs show how to describe current outputs of
>> +  either integrated multi-color LED elements (like RGB, RGBW, RGBWA-UV
>> +  etc.) or standalone LEDs, to achieve logically grouped multi-color LED
>> +  modules. This is achieved by adding multi-led nodes layer to the
>> +  monochrome LED bindings.
>> +  The nodes and properties defined in this document are unique to the multicolor
>> +  LED class.  Common LED nodes and properties are inherited from the common.txt
>> +  within this documentation directory.
>> +
>> +patternProperties:
>> +  "^multi-led@([0-9a-f])$":
>> +    type: object
>> +    description: Represents the LEDs that are to be grouped.
>> +    properties:
>> +      #allOf:
>> +        #- $ref: "common.yaml#"
> Why is this commented out? Other than it is wrong. Uncommented, this
> would be defining a DT property called 'allOf'.
>
> You can drop 'allOf' now. '$ref' should be at the level of 'properties'.

I used the example from the rohm,bd71828-leds.yaml where these lines appear.

So that binding is wrong as well.

>> +
>> +      color:
>> +        $ref: /schemas/types.yaml#definitions/uint32
> common.yaml already defines the type, so drop this.

OK

Dan