From: Marek Vasut <marex@denx.de>
To: Rob Herring <robh@kernel.org>
Cc: Pavel Machek <pavel@ucw.cz>,
linux-leds@vger.kernel.org,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: leds: Document none trigger
Date: Mon, 8 Nov 2021 23:49:09 +0100 [thread overview]
Message-ID: <b99715e7-4bf8-26e4-a081-6d434ce4ec06@denx.de> (raw)
In-Reply-To: <YYljmDDXH5zvBgjC@robh.at.kernel.org>
On 11/8/21 6:51 PM, Rob Herring wrote:
> On Sun, Oct 24, 2021 at 08:05:55PM +0200, Marek Vasut wrote:
>> On 10/24/21 10:41 AM, Pavel Machek wrote:
>>> Hi!
>>>
>>>> There is a trigger called "none" which triggers never, add it to the
>>>> list of valid trigger values.
>>>
>>> We can do this, but is it useful? If you avoid putting trigger
>>> property, it will do the same thing.
>>
>> It's not that simple. If you have a DT which specifies a trigger type and a
>> DTO which overrides that trigger type, then the DTO cannot remove the
>> trigger from the base DT, it has to set trigger type to "none". So I believe
>> there is a valid use case for existence of the "none" type.
>
> Sounds like an incorrect partitioning of base and overlays IMO.
Note that you might not have control over the base DT.
> There's also already /delete-property/ directive though I'm not sure if
> that's supported in overlays.
How do you encode /delete-property/ into the DT overlay blob .dtbo ?
I thought that /delete-property/ and /delete-node/ was a DTC directive
and the DT blob has no way to represent either ?
prev parent reply other threads:[~2021-11-08 22:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-24 0:23 [PATCH 1/2] dt-bindings: leds: Document none trigger Marek Vasut
2021-10-24 0:23 ` [PATCH 2/2] dt-bindings: leds: Document mmc trigger Marek Vasut
2021-10-24 8:40 ` Pavel Machek
2021-10-24 18:03 ` Marek Vasut
2021-10-24 14:27 ` Rob Herring
2021-10-24 8:41 ` [PATCH 1/2] dt-bindings: leds: Document none trigger Pavel Machek
2021-10-24 18:05 ` Marek Vasut
2021-11-08 17:51 ` Rob Herring
2021-11-08 22:49 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b99715e7-4bf8-26e4-a081-6d434ce4ec06@denx.de \
--to=marex@denx.de \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).