From: Marek Vasut <marex@denx.de>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-leds@vger.kernel.org,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: leds: Document mmc trigger
Date: Sun, 24 Oct 2021 20:03:32 +0200 [thread overview]
Message-ID: <dc499e2d-6f15-d556-b61d-b4b5748ea98a@denx.de> (raw)
In-Reply-To: <20211024084010.GA32488@duo.ucw.cz>
On 10/24/21 10:40 AM, Pavel Machek wrote:
> Hi!
>
>> The mmc subsystem supports triggering leds on card activity, document
>> the trigger value here. The value is a pattern in this case.
>
> I don't believe this is suitable as devicetree does not know about mmc
> numbers.
There are multiple instances of this trigger type in existing DTs, see:
$ git grep linux.default-trigger.=..mmc | wc -l
85
So what alternative do you suggest ?
next prev parent reply other threads:[~2021-10-24 18:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-24 0:23 [PATCH 1/2] dt-bindings: leds: Document none trigger Marek Vasut
2021-10-24 0:23 ` [PATCH 2/2] dt-bindings: leds: Document mmc trigger Marek Vasut
2021-10-24 8:40 ` Pavel Machek
2021-10-24 18:03 ` Marek Vasut [this message]
2021-10-24 14:27 ` Rob Herring
2021-10-24 8:41 ` [PATCH 1/2] dt-bindings: leds: Document none trigger Pavel Machek
2021-10-24 18:05 ` Marek Vasut
2021-11-08 17:51 ` Rob Herring
2021-11-08 22:49 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc499e2d-6f15-d556-b61d-b4b5748ea98a@denx.de \
--to=marex@denx.de \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).