From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: "Guido Günther" <agx@sigxcpu.org>, "Pavel Machek" <pavel@ucw.cz>,
"Dan Murphy" <dmurphy@ti.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/5] leds: lm3692x: Probing and flag fixes
Date: Tue, 24 Sep 2019 20:20:58 +0200 [thread overview]
Message-ID: <ba610ed3-19b7-3e10-7032-453e0cb05704@gmail.com> (raw)
In-Reply-To: <cover.1569100154.git.agx@sigxcpu.org>
Hi Guido,
Thank you for the update.
On 9/21/19 11:12 PM, Guido Günther wrote:
> The driver currently returns success on init although probing fails and
> register setup uses flag values from other registers which is confusing when
> reading the driver. This series cleans this up.
>
> Changes from v2:
> - Add Acked-by from Pavel Machek, thanks!
> https://lore.kernel.org/linux-leds/20190920114743.GA21835@amd/
> - As per review comment from Dan Murphy
> https://lore.kernel.org/linux-leds/2bde2870-08a3-38b9-9cd7-fee0e2107743@ti.com/
> - rename return value from ret2 to reg_ret
> - print error code
>
> Changes from v1:
> - Add reviewed by's from Dan Murphy, thanks!
> https://lore.kernel.org/linux-leds/cover.1568772964.git.agx@sigxcpu.org/T/#mc183f3f65931371fa9f9ca2e0e83e0b85010f24b
> https://lore.kernel.org/linux-leds/cover.1568772964.git.agx@sigxcpu.org/T/#mb845fac36327a5d5dd03fe7e988eef0eb5626f82
> https://lore.kernel.org/linux-leds/cover.1568772964.git.agx@sigxcpu.org/T/#m995bce73dda3e3bd4f0c2e8f98cbd04a39c13832
> - As per review comment from Dan Murphy
> - Don't drop error message when disabling the regulator fails
> https://lore.kernel.org/linux-leds/cover.1568772964.git.agx@sigxcpu.org/T/#m2ab6dc33b7277b71a197c3747847f1c4d9d9c1d8
> - Handle -ENODEV (when the regulator is not set)
> https://lore.kernel.org/linux-leds/cover.1568772964.git.agx@sigxcpu.org/T/#mf6212c29bbfa37b43200ea2c9744074de4f068ee
> - Add Acked-by from Pavel Machek, thanks!
> https://lore.kernel.org/linux-leds/20190919095415.GA29939@amd/
>
> Guido Günther (5):
> leds: lm3692x: Print error value on dev_err
> leds: lm3692x: Don't overwrite return value in error path
> leds: lm3692x: Handle failure to probe the regulator
> leds: lm3692x: Use flags from LM3692X_BOOST_CTRL
> leds: lm3692x: Use flags from LM3692X_BRT_CTRL
>
> drivers/leds/leds-lm3692x.c | 47 +++++++++++++++++++++++--------------
> 1 file changed, 30 insertions(+), 17 deletions(-)
>
Patch set applied to the for-5.5 branch of linux-leds.git.
--
Best regards,
Jacek Anaszewski
prev parent reply other threads:[~2019-09-24 18:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-21 21:12 [PATCH v3 0/5] leds: lm3692x: Probing and flag fixes Guido Günther
2019-09-21 21:12 ` [PATCH v3 1/5] leds: lm3692x: Print error value on dev_err Guido Günther
2019-09-21 21:12 ` [PATCH v3 2/5] leds: lm3692x: Don't overwrite return value in error path Guido Günther
2019-09-23 14:16 ` Dan Murphy
2019-09-21 21:12 ` [PATCH v3 3/5] leds: lm3692x: Handle failure to probe the regulator Guido Günther
2019-09-23 14:17 ` Dan Murphy
2019-09-21 21:12 ` [PATCH v3 4/5] leds: lm3692x: Use flags from LM3692X_BOOST_CTRL Guido Günther
2019-09-21 21:12 ` [PATCH v3 5/5] leds: lm3692x: Use flags from LM3692X_BRT_CTRL Guido Günther
2019-09-24 18:20 ` Jacek Anaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba610ed3-19b7-3e10-7032-453e0cb05704@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=agx@sigxcpu.org \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).