Linux-LEDs Archive on lore.kernel.org
 help / color / Atom feed
From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Rob Herring <robh+dt@kernel.org>, Jean-Jacques Hiblot <jjhiblot@ti.com>
Cc: Pavel Machek <pavel@ucw.cz>, Sebastian Reichel <sre@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Lee Jones <lee.jones@linaro.org>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Dan Murphy <dmurphy@ti.com>,
	Linux LED Subsystem <linux-leds@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>
Subject: Re: [PATCH v9 4/5] dt-bindings: backlight: Add led-backlight binding
Date: Tue, 8 Oct 2019 19:17:29 +0200
Message-ID: <edadb121-cebd-b8ea-e07d-f5495a581dfd@gmail.com> (raw)
In-Reply-To: <CAL_JsqL8b0gWPTt3oJ8ScY_AwP+uB__dZP6Eednfa5Fq9vAptw@mail.gmail.com>

On 10/8/19 5:00 PM, Rob Herring wrote:
> On Tue, Oct 8, 2019 at 8:30 AM Jean-Jacques Hiblot <jjhiblot@ti.com> wrote:
>>
>> Rob,
>>
>> On 08/10/2019 14:51, Jean-Jacques Hiblot wrote:
>>> Hi Rob,
>>>
>>> On 07/10/2019 18:15, Rob Herring wrote:
>>>> Please send DT bindings to DT list or it's never in my queue. IOW,
>>>> send patches to the lists that get_maintainers.pl tells you to.
>>>>
>>>> On Mon, Oct 7, 2019 at 7:45 AM Jean-Jacques Hiblot <jjhiblot@ti.com>
>>>> wrote:
>>>>> Add DT binding for led-backlight.
>>>>>
>>>>> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
>>>>> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
>>>>> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
>>>>> ---
>>>>>   .../bindings/leds/backlight/led-backlight.txt | 28
>>>>> +++++++++++++++++++
>>>>>   1 file changed, 28 insertions(+)
>>>>>   create mode 100644
>>>>> Documentation/devicetree/bindings/leds/backlight/led-backlight.txt
>>>> Please make this a DT schema.
>>>
>>> OK.
>>>
>>> BTW I used "make dt_binding_check" but had to fix a couple of YAMLs
>>> file to get it to work. Do you have a kernel tree with already all the
>>> YAML files in good shape ? Or do you want me to post the changes to
>>> devicetree@vger.kernel.org ?
>>>
>>>
>>>>
>>>>> diff --git
>>>>> a/Documentation/devicetree/bindings/leds/backlight/led-backlight.txt
>>>>> b/Documentation/devicetree/bindings/leds/backlight/led-backlight.txt
>>>>> new file mode 100644
>>>>> index 000000000000..4c7dfbe7f67a
>>>>> --- /dev/null
>>>>> +++
>>>>> b/Documentation/devicetree/bindings/leds/backlight/led-backlight.txt
>>>>> @@ -0,0 +1,28 @@
>>>>> +led-backlight bindings
>>>>> +
>>>>> +This binding is used to describe a basic backlight device made of
>>>>> LEDs.
>>>>> +It can also be used to describe a backlight device controlled by
>>>>> the output of
>>>>> +a LED driver.
>>>>> +
>>>>> +Required properties:
>>>>> +  - compatible: "led-backlight"
>>>>> +  - leds: a list of LEDs
>>>> 'leds' is already used as a node name and mixing is not ideal.

for the record: child node names (if that was what you had on mind)
have singular form 'led'.

>>>> We already have 'flash-leds' in use and with the same definition, so
>>>> lets continue that and use 'backlight-leds'.
>>> OK
>>
>> I am taking that back. I have added of_get_led() and devm_of_get_led()
>> to the LED core to make it easier to get a LED from the DT. I modeled
>> the interface like it is done for PWM, PHYs or clocks. The property
>> containing list/array of phandle  is always named the same. To get one
>> particular PWM/PHY/clock, a identifier (name or integer) must be provided.
> 
> It can be done as we do support that with '-gpios', but yes, it is a
> bit more painful to deal with.
> 
>> So unless there is a strong incentive to do otherwise I's rather keep
>> this name here.
> 
> In that case, this needs to be documented as a common LED binding, not
> something hidden away in this binding.
> 
> Rob
> 

-- 
Best regards,
Jacek Anaszewski

  parent reply index

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-07 12:44 [PATCH v9 0/5] Add a generic driver for LED-based backlight Jean-Jacques Hiblot
2019-10-07 12:44 ` [PATCH v9 1/5] leds: populate the device's of_node Jean-Jacques Hiblot
2019-10-07 12:44 ` [PATCH v9 2/5] leds: Add of_led_get() and led_put() Jean-Jacques Hiblot
2019-10-07 12:44 ` [PATCH v9 3/5] leds: Add managed API to get a LED from a device driver Jean-Jacques Hiblot
2019-10-13 12:09   ` Pavel Machek
2019-10-07 12:44 ` [PATCH v9 4/5] dt-bindings: backlight: Add led-backlight binding Jean-Jacques Hiblot
2019-10-07 16:15   ` Rob Herring
2019-10-08 12:51     ` Jean-Jacques Hiblot
2019-10-08 13:30       ` Jean-Jacques Hiblot
2019-10-08 15:00         ` Rob Herring
2019-10-08 17:17           ` Jacek Anaszewski
2019-10-08 17:17           ` Jacek Anaszewski [this message]
2019-10-08 20:00             ` Rob Herring
2019-10-09 18:31               ` Jacek Anaszewski
2019-10-08 14:52       ` Rob Herring
2019-10-07 12:44 ` [PATCH v9 5/5] backlight: add led-backlight driver Jean-Jacques Hiblot

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=edadb121-cebd-b8ea-e07d-f5495a581dfd@gmail.com \
    --to=jacek.anaszewski@gmail.com \
    --cc=daniel.thompson@linaro.org \
    --cc=dmurphy@ti.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jjhiblot@ti.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    --cc=sre@kernel.org \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-LEDs Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-leds/0 linux-leds/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-leds linux-leds/ https://lore.kernel.org/linux-leds \
		linux-leds@vger.kernel.org
	public-inbox-index linux-leds

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-leds


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git