[linux-lvm] [PATCH] fix link to dmsetup.static when /sbin and /usr/sbin are not the same

[linux-lvm] [PATCH] fix link to dmsetup.static when /sbin and /usr/sbin are not the same

[Thomas Orgis]

[-- Attachment #1.1: Type: text/plain, Size: 913 bytes --]

Hi,

LVM2.2.02.168 (and earlier) has that in Makefile.in

install_dmsetup_dynamic: dmsetup
	$(INSTALL_PROGRAM) -D $< $(sbindir)/$(<F)
	$(LN_S) -f $(<F) $(sbindir)/dmstats

install_dmsetup_static: dmsetup.static
	$(INSTALL_PROGRAM) -D $< $(staticdir)/$(<F)
	$(LN_S) -f $(<F) $(sbindir)/dmstats

This results in

lrwxrwxrwx 1 root root 14  4. Dez 12:33 /sbin/dmstats -> dmsetup.static

… while the target for that link is

-r-xr-xr-x 1 root root 1252120  4. Dez 12:33 /usr/sbin/dmsetup.static

I suppose the second link command should create $(staticdir)/dmstats.
Regardless of whether your /sbin is a link to /usr/sbin or the other
way round, this seems more proper. I am not sure if we want to enforce
the link pointing always to the static binary if they end up in the
same directory.

Anyhow, I attached the trivial patch that avoids a broken symlink.


Alrighty then,

Thomas

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: lvm-static-dmstats.patch --]
[-- Type: text/x-patch, Size: 401 bytes --]

--- LVM2.2.02.168/tools/Makefile.in.orig	2016-12-04 12:37:11.181407587 +0100
+++ LVM2.2.02.168/tools/Makefile.in	2016-12-04 12:37:16.251407927 +0100
@@ -209,7 +209,7 @@
 
 install_dmsetup_static: dmsetup.static
 	$(INSTALL_PROGRAM) -D $< $(staticdir)/$(<F)
-	$(LN_S) -f $(<F) $(sbindir)/dmstats
+	$(LN_S) -f $(<F) $(staticdir)/dmstats
 
 install_device-mapper: $(INSTALL_DMSETUP_TARGETS)
 

[-- Attachment #2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 819 bytes --]