linux-lvm.redhat.com archive mirror
 help / color / mirror / Atom feed
* [linux-lvm] lvm_proc_get_info()
@ 1999-03-31 18:37 Michael Marxmeier
  0 siblings, 0 replies; only message in thread
From: Michael Marxmeier @ 1999-03-31 18:37 UTC (permalink / raw)
  To: linux-lvm

There is a minor problem in lvm.c / lvm_proc_get_info()

lvm_proc_get_info() returns -1 on EOF which results in a bogus EPERM 
returned to user mode. Try a cat /proc/lvm to see the effect.
Returning 0 should indicate the EOF condition.

Trivial patch against 0.6 is below. Obviously this also needs to
be applied against linux/drivers/block/lvm.c


Michael


--- /usr/src/LVM/0.6/kernel/lvm.c       Fri Feb 26 01:46:28 1999
+++ lvm.c       Wed Mar 31 10:28:30 1999
@@ -1675,7 +1675,7 @@
    if ( pos > sz - 1) {
       vfree ( buf);
       buf = NULL;
-      return -1;
+      return 0;
    }
 
    *start = &buf[pos];

-- 
Michael Marxmeier           Marxmeier Software GmbH
E-Mail: mike@msede.com      Besenbruchstrasse 9
Voice : +49 202 2431440     42285 Wuppertal, Germany
Fax   : +49 202 2431420     http://www.msede.com/

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~1999-03-31 18:37 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1999-03-31 18:37 [linux-lvm] lvm_proc_get_info() Michael Marxmeier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).