From: "heming.zhao@suse.com" <heming.zhao@suse.com>
To: linux-lvm@redhat.com
Subject: Re: [linux-lvm] [PATCH] tests: use correct RA size, underly dev & delay time.
Date: Wed, 12 Aug 2020 21:32:40 +0800 [thread overview]
Message-ID: <c86aeb1a-f7fd-000b-228d-e43029f25478@suse.com> (raw)
In-Reply-To: <1597231111-28086-1-git-send-email-heming.zhao@suse.com>
a little more info about my patch.
in one of my test env, system default read_ahead size is 1024 sector (512K),
which bigger than 128k in test case. which causes _set_dev_node_read_ahead() to deny
to set up RA.
On 8/12/20 7:18 PM, Zhao Heming wrote:
> lvconvert-repair-raid.sh:
> - in some env, the delay=0 is too short to set up env.
>
> lvcreate-usage.sh:
> - use correct underlying dev for brd & loop devices.
> - read ahead size should equal or bigger than current system value
>
> read-ahead.sh:
> - use current system ra_size PLUS 128 to set up new ra_size.
> for detail, refer _set_dev_node_read_ahead in libdm-common.c
>
> Signed-off-by: Zhao Heming <heming.zhao@suse.com>
> ---
> test/shell/lvconvert-repair-raid.sh | 2 +-
> test/shell/lvcreate-usage.sh | 11 ++++++-----
> test/shell/read-ahead.sh | 6 ++++--
> 3 files changed, 11 insertions(+), 8 deletions(-)
>
next prev parent reply other threads:[~2020-08-12 13:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 11:18 [linux-lvm] [PATCH] tests: use correct RA size, underly dev & delay time Zhao Heming
2020-08-12 13:32 ` heming.zhao [this message]
2020-08-13 19:01 ` Zdenek Kabelac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c86aeb1a-f7fd-000b-228d-e43029f25478@suse.com \
--to=heming.zhao@suse.com \
--cc=linux-lvm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).