[PATCH] net/sun3_82586: Fix return value of sun3_82586_probe()

[PATCH] net/sun3_82586: Fix return value of sun3_82586_probe()

[Geert Uytterhoeven]

drivers/net/ethernet/i825xx/sun3_82586.c: In function ‘sun3_82586_probe’:
drivers/net/ethernet/i825xx/sun3_82586.c:317:9: warning: returning ‘struct net_device *’ from a function with return type ‘int’ makes integer from pointer without a cast [-Wint-conversion]
  317 |  return dev;
      |         ^~~

The return type of sun3_82586_probe() was changed, but one return value
was forgotten to be updated.

Fixes: e179d78ee11a70e2 ("m68k: remove legacy probing")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/net/ethernet/i825xx/sun3_82586.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/i825xx/sun3_82586.c b/drivers/net/ethernet/i825xx/sun3_82586.c
index 8c57e6e36647e9d3..ec4c5cfe2d68e8ed 100644
--- a/drivers/net/ethernet/i825xx/sun3_82586.c
+++ b/drivers/net/ethernet/i825xx/sun3_82586.c
@@ -314,7 +314,7 @@ static int __init sun3_82586_probe(void)
 	err = register_netdev(dev);
 	if (err)
 		goto out2;
-	return dev;
+	return 0;
 
 out2:
 	release_region(ioaddr, SUN3_82586_TOTAL_SIZE);
-- 
2.25.1

Re: [PATCH] net/sun3_82586: Fix return value of sun3_82586_probe()

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Wed,  1 Sep 2021 14:17:35 +0200 you wrote:
> drivers/net/ethernet/i825xx/sun3_82586.c: In function ‘sun3_82586_probe’:
> drivers/net/ethernet/i825xx/sun3_82586.c:317:9: warning: returning ‘struct net_device *’ from a function with return type ‘int’ makes integer from pointer without a cast [-Wint-conversion]
>   317 |  return dev;
>       |         ^~~
> 
> The return type of sun3_82586_probe() was changed, but one return value
> was forgotten to be updated.
> 
> [...]

Here is the summary with links:
  - net/sun3_82586: Fix return value of sun3_82586_probe()
    https://git.kernel.org/netdev/net/c/66abf5fb4cf7

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html