From: David Miller <davem@davemloft.net>
To: fthain@telegraphics.com.au
Cc: netdev@vger.kernel.org, linux-m68k@vger.kernel.org,
linux-kernel@vger.kernel.org, linux@armlinux.org.uk,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net v4 02/13] net/8390: Fix msg_enable patch snafu
Date: Wed, 14 Feb 2018 17:15:58 -0500 (EST) [thread overview]
Message-ID: <20180214.171558.1617880686804101923.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LNX.2.21.1802150857480.8@nippy.intranet>
From: Finn Thain <fthain@telegraphics.com.au>
Date: Thu, 15 Feb 2018 09:11:13 +1100 (AEDT)
> On Tue, 13 Feb 2018, David Miller wrote:
>
>> > I think you have overlooked those modules which offer no way to set
>> > p->msg_enable, i.e. ax88796, axnet_cs, etherh, hydra, mac8390,
>> > mcf8390, pcnet_cs and zorro8390.
>>
>> Then that's a bug, we have a very simple easy to implement interface for
>> setting this (ethtool).
>>
>> And by adding the simple hook, you will make these older drivers easier
>> to debug for the few people still using them.
>
> Have you considered that implementing the ethtool hooks in the core driver
> might allow removal of all 8390 driver 'msg_enable' module parameters and
> msglevel ethtool hooks added by c45f812f0280, excepting those in the core
> driver? But even if we did that, it seems to me that we still need this
> patch.
No, because the module parameter lets you set the default msg level at
the time the driver loads, so you can control messages printed very
early on before it is practical to invoke ethtool and set the msg
level.
This is why most drivers have this module parameter, and implement
such a scheme.
next prev parent reply other threads:[~2018-02-14 22:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 3:08 [PATCH net v4 00/13] Fixes, cleanup and modernization for some legacy ethernet NIC drivers Finn Thain
2018-02-12 3:08 ` [PATCH net v4 08/13] net/mac89x0: Replace custom debug logging with netif_* calls Finn Thain
2018-02-12 3:08 ` [PATCH net v4 01/13] net/8390: Remove redundant make dependencies Finn Thain
2018-02-12 8:16 ` Geert Uytterhoeven
2018-02-12 3:08 ` [PATCH net v4 10/13] net/mac8390: Fix log messages Finn Thain
2018-02-12 3:08 ` [PATCH net v4 04/13] net/macmace: Fix and clean up " Finn Thain
2018-02-12 3:08 ` [PATCH net v4 11/13] net/macsonic: Convert to nubus_driver Finn Thain
2018-02-12 3:08 ` [PATCH net v4 02/13] net/8390: Fix msg_enable patch snafu Finn Thain
2018-02-12 15:39 ` David Miller
2018-02-13 5:03 ` Finn Thain
2018-02-13 14:58 ` David Miller
2018-02-14 22:11 ` Finn Thain
2018-02-14 22:15 ` David Miller [this message]
2018-02-16 3:47 ` Finn Thain
2018-02-12 3:08 ` [PATCH net v4 06/13] net/mac89x0: Convert to platform_driver Finn Thain
2018-02-12 8:25 ` Geert Uytterhoeven
2018-02-12 3:08 ` [PATCH net v4 07/13] net/mac89x0: Fix and modernize log messages Finn Thain
2018-02-12 3:08 ` [PATCH net v4 05/13] net/mac89x0: Remove dead or unreachable code Finn Thain
2018-02-12 3:08 ` [PATCH net v4 03/13] net/smc9194: Remove bogus CONFIG_MAC reference Finn Thain
2018-02-12 3:08 ` [PATCH net v4 09/13] net/mac8390: Convert to nubus_driver Finn Thain
2018-02-12 8:29 ` Geert Uytterhoeven
2018-02-13 5:03 ` Finn Thain
2018-02-12 3:08 ` [PATCH net v4 12/13] net/sonic: Clean up and modernize log messages Finn Thain
2018-02-12 3:08 ` [PATCH net v4 13/13] net/sonic: Replace custom debug logging with netif_* calls Finn Thain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180214.171558.1617880686804101923.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fthain@telegraphics.com.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).