From: Finn Thain <fthain@telegraphics.com.au>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-m68k@vger.kernel.org,
linux-kernel@vger.kernel.org, linux@armlinux.org.uk,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net v4 02/13] net/8390: Fix msg_enable patch snafu
Date: Fri, 16 Feb 2018 14:47:58 +1100 (AEDT) [thread overview]
Message-ID: <alpine.LNX.2.21.1802161203480.8@nippy.intranet> (raw)
In-Reply-To: <20180214.171558.1617880686804101923.davem@davemloft.net>
On Wed, 14 Feb 2018, David Miller wrote:
> > Have you considered that implementing the ethtool hooks in the core
> > driver might allow removal of all 8390 driver 'msg_enable' module
> > parameters and msglevel ethtool hooks added by c45f812f0280, excepting
> > those in the core driver? But even if we did that, it seems to me that
> > we still need this patch.
>
> No, because the module parameter lets you set the default msg level at
> the time the driver loads, so you can control messages printed very
> early on before it is practical to invoke ethtool and set the msg level.
>
> This is why most drivers have this module parameter, and implement
> such a scheme.
Among the 8390 drivers, so far only ne2k-pci implements that scheme.
This patch implements that scheme for ax88796 and etherh as well, by
making better use of the msg_enable module parameter in lib8390.c.
The axnet_cs and pcnet_cs modules lack the msglevel ethtool ops and the
msg_enable module parameters.
The remaining nine modules lack just the ethtool ops. If you like I will
write additional patches to implement the missing ethtool ops or module
parameters or both (?)
This small patch already addresses the use-case in which the end-user
needs to enable (for example) probe messages for some or all 8390 drivers.
Thoughts?
--
next prev parent reply other threads:[~2018-02-16 3:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 3:08 [PATCH net v4 00/13] Fixes, cleanup and modernization for some legacy ethernet NIC drivers Finn Thain
2018-02-12 3:08 ` [PATCH net v4 08/13] net/mac89x0: Replace custom debug logging with netif_* calls Finn Thain
2018-02-12 3:08 ` [PATCH net v4 01/13] net/8390: Remove redundant make dependencies Finn Thain
2018-02-12 8:16 ` Geert Uytterhoeven
2018-02-12 3:08 ` [PATCH net v4 10/13] net/mac8390: Fix log messages Finn Thain
2018-02-12 3:08 ` [PATCH net v4 04/13] net/macmace: Fix and clean up " Finn Thain
2018-02-12 3:08 ` [PATCH net v4 11/13] net/macsonic: Convert to nubus_driver Finn Thain
2018-02-12 3:08 ` [PATCH net v4 02/13] net/8390: Fix msg_enable patch snafu Finn Thain
2018-02-12 15:39 ` David Miller
2018-02-13 5:03 ` Finn Thain
2018-02-13 14:58 ` David Miller
2018-02-14 22:11 ` Finn Thain
2018-02-14 22:15 ` David Miller
2018-02-16 3:47 ` Finn Thain [this message]
2018-02-12 3:08 ` [PATCH net v4 06/13] net/mac89x0: Convert to platform_driver Finn Thain
2018-02-12 8:25 ` Geert Uytterhoeven
2018-02-12 3:08 ` [PATCH net v4 07/13] net/mac89x0: Fix and modernize log messages Finn Thain
2018-02-12 3:08 ` [PATCH net v4 05/13] net/mac89x0: Remove dead or unreachable code Finn Thain
2018-02-12 3:08 ` [PATCH net v4 03/13] net/smc9194: Remove bogus CONFIG_MAC reference Finn Thain
2018-02-12 3:08 ` [PATCH net v4 09/13] net/mac8390: Convert to nubus_driver Finn Thain
2018-02-12 8:29 ` Geert Uytterhoeven
2018-02-13 5:03 ` Finn Thain
2018-02-12 3:08 ` [PATCH net v4 12/13] net/sonic: Clean up and modernize log messages Finn Thain
2018-02-12 3:08 ` [PATCH net v4 13/13] net/sonic: Replace custom debug logging with netif_* calls Finn Thain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.21.1802161203480.8@nippy.intranet \
--to=fthain@telegraphics.com.au \
--cc=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).