From: Peter Zijlstra <peterz@infradead.org>
To: Will Deacon <will@kernel.org>
Cc: Greg Ungerer <gerg@linux-m68k.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] Rewrite Motorola MMU page-table layout
Date: Fri, 31 Jan 2020 12:14:59 +0100 [thread overview]
Message-ID: <20200131111459.GO14946@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200131102239.GB14914@hirez.programming.kicks-ass.net>
On Fri, Jan 31, 2020 at 11:22:39AM +0100, Peter Zijlstra wrote:
> On Fri, Jan 31, 2020 at 09:38:13AM +0000, Will Deacon wrote:
>
> > > This series breaks compilation for the ColdFire (with MMU) variant of
> > > the m68k family:
>
> That's like the same I had reported by the build robots for sun3, which
> I fixed by frobbing pgtable_t. That said, this is probably a more
> consistent change.
>
> One note below:
>
>
> > -static inline struct page *pte_alloc_one(struct mm_struct *mm)
> > +static inline pgtable_t pte_alloc_one(struct mm_struct *mm)
> > {
> > struct page *page = alloc_pages(GFP_DMA, 0);
> > pte_t *pte;
> > @@ -54,20 +55,19 @@ static inline struct page *pte_alloc_one(struct mm_struct *mm)
> > return NULL;
> > }
> >
> > - pte = kmap(page);
> > - if (pte) {
> > - clear_page(pte);
> > - __flush_page_to_ram(pte);
> > - flush_tlb_kernel_page(pte);
> > - nocache_page(pte);
> > - }
> > - kunmap(page);
> > + pte = page_address(page);
> > + clear_page(pte);
> > + __flush_page_to_ram(pte);
> > + flush_tlb_kernel_page(pte);
> > + nocache_page(pte);
>
> See how it does the nocache dance ^
> So either, alloc_one() shouldn't either, or it's all buggered.
Damn, we weren't going to touch coldfire! :-))
So now I found the coldfire docs, and it looks like this thing is a
software tlb-miss arch, so there is no reason what so ever for this to
be nocache. I'll 'fix' that.
next prev parent reply other threads:[~2020-01-31 11:15 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 10:39 [PATCH 0/5] Rewrite Motorola MMU page-table layout Peter Zijlstra
2020-01-29 10:39 ` [PATCH 1/5] m68k,mm: Restructure motorola mmu " Peter Zijlstra
2020-01-29 10:39 ` [PATCH 2/5] m68k,mm: Improve kernel_page_table() Peter Zijlstra
2020-01-29 10:39 ` [PATCH 3/5] m68k,mm: Use table allocator for pgtables Peter Zijlstra
2020-01-29 12:11 ` Will Deacon
2020-01-29 12:24 ` Peter Zijlstra
2020-01-29 10:39 ` [PATCH 4/5] m68k,mm: Extend table allocator for multiple sizes Peter Zijlstra
2020-01-29 12:17 ` Will Deacon
2020-01-29 12:43 ` Peter Zijlstra
2020-01-29 13:15 ` Will Deacon
2020-01-29 10:39 ` [PATCH 5/5] m68k,mm: Fully initialize the page-table allocator Peter Zijlstra
2020-01-29 10:49 ` [PATCH 0/5] Rewrite Motorola MMU page-table layout John Paul Adrian Glaubitz
2020-01-29 11:54 ` Peter Zijlstra
2020-01-29 12:05 ` John Paul Adrian Glaubitz
2020-01-29 12:30 ` Peter Zijlstra
2020-01-29 18:52 ` Michael Schmitz
2020-01-29 19:31 ` Peter Zijlstra
2020-01-30 7:31 ` Michael Schmitz
2020-01-30 8:16 ` Peter Zijlstra
2020-01-30 19:12 ` Michael Schmitz
2020-01-31 6:31 ` Greg Ungerer
2020-01-31 9:38 ` Will Deacon
2020-01-31 10:22 ` Peter Zijlstra
2020-01-31 11:14 ` Peter Zijlstra [this message]
2020-01-31 11:18 ` Will Deacon
2020-01-31 11:31 ` Peter Zijlstra
2020-01-31 11:43 ` Will Deacon
2020-01-31 13:04 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200131111459.GO14946@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=geert@linux-m68k.org \
--cc=gerg@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).