[PATCH] zorro: Fix address space collision message with RAM expansion boards

[PATCH] zorro: Fix address space collision message with RAM expansion boards

[Geert Uytterhoeven]

When booting Linux on an Amiga with BigRAMPlus Zorro expansion board:

    zorro: Address space collision on device Zorro device 12128600 (Individual Computers) [??? 0x50000000-]

This happens because the address space occupied by the BigRAMPlus Zorro
device is already in use, as it is part of system RAM.  Hence the
message is harmless.

Zorro memory expansion boards have the ERTF_MEMLIST flag set, which
tells AmigaOS to link the board's RAM into the free memory list.  While
we could skip registering the board resource if this flag is set, that
may cause issues with Zorro II RAM excluded in a memfile.

Hence fix the issue by just ignoring the error if ERTF_MEMLIST is set.

Reported-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/zorro/zorro.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/zorro/zorro.c b/drivers/zorro/zorro.c
index 47c733817903f303..1b9928648583193c 100644
--- a/drivers/zorro/zorro.c
+++ b/drivers/zorro/zorro.c
@@ -181,7 +181,7 @@ static int __init amiga_zorro_probe(struct platform_device *pdev)
 		z->resource.name = z->name;
 		r = zorro_find_parent_resource(pdev, z);
 		error = request_resource(r, &z->resource);
-		if (error)
+		if (error && !(z->rom.er_Type & ERTF_MEMLIST))
 			dev_err(&bus->dev,
 				"Address space collision on device %s %pR\n",
 				z->name, &z->resource);
-- 
2.17.1

Re: [PATCH] zorro: Fix address space collision message with RAM expansion boards

[Geert Uytterhoeven]

On Mon, Jul 13, 2020 at 9:24 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> When booting Linux on an Amiga with BigRAMPlus Zorro expansion board:
>
>     zorro: Address space collision on device Zorro device 12128600 (Individual Computers) [??? 0x50000000-]
>
> This happens because the address space occupied by the BigRAMPlus Zorro
> device is already in use, as it is part of system RAM.  Hence the
> message is harmless.
>
> Zorro memory expansion boards have the ERTF_MEMLIST flag set, which
> tells AmigaOS to link the board's RAM into the free memory list.  While
> we could skip registering the board resource if this flag is set, that
> may cause issues with Zorro II RAM excluded in a memfile.
>
> Hence fix the issue by just ignoring the error if ERTF_MEMLIST is set.
>
> Reported-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Applied, and queued in the m68k for-v5.10 branch.

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] zorro: Fix address space collision message with RAM expansion boards

[John Paul Adrian Glaubitz]

On 8/26/20 1:28 PM, Geert Uytterhoeven wrote:
> On Mon, Jul 13, 2020 at 9:24 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>> When booting Linux on an Amiga with BigRAMPlus Zorro expansion board:
>>
>>     zorro: Address space collision on device Zorro device 12128600 (Individual Computers) [??? 0x50000000-]
>>
>> This happens because the address space occupied by the BigRAMPlus Zorro
>> device is already in use, as it is part of system RAM.  Hence the
>> message is harmless.
>>
>> Zorro memory expansion boards have the ERTF_MEMLIST flag set, which
>> tells AmigaOS to link the board's RAM into the free memory list.  While
>> we could skip registering the board resource if this flag is set, that
>> may cause issues with Zorro II RAM excluded in a memfile.
>>
>> Hence fix the issue by just ignoring the error if ERTF_MEMLIST is set.
>>
>> Reported-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> 
> Applied, and queued in the m68k for-v5.10 branch.

Oh, that reminds me. I should dig out the Big-RAM-Plus again. I still haven't
found it after my last move but I know where to find it (hopefully ;-)).

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913