linux-m68k.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Schmitz <schmitzmic@gmail.com>
To: David Miller <davem@davemloft.net>, alex@kazik.de
Cc: netdev@vger.kernel.org, linux-m68k@vger.kernel.org,
	rolf.anders@physik.uni-augsburg.de
Subject: Re: [PATCH net-next] Amiga PCMCIA 100 MBit card support
Date: Sat, 22 Dec 2018 10:30:58 +1300	[thread overview]
Message-ID: <2a960bfa-000a-eb14-814b-476da5c1f5df@gmail.com> (raw)
In-Reply-To: <20181220.161053.1268735869147094096.davem@davemloft.net>

Dave,

Am 21.12.2018 um 13:10 schrieb David Miller:
> From: ALeX Kazik <alex@kazik.de>
> Date: Wed, 19 Dec 2018 23:24:32 +0100
>
>> +	bool "PCMCIA NE2000 100MBit support"
>> +	default n
>> +	depends on ARM_ETHERH=n && AX88796=n && HYDRA=n && MAC8390=n
>> +	depends on MCF8390=n && NE2000=n && NE2K_PCI=n && PCMCIA_AXNET=n
>> +	depends on PCMCIA_PCNET=n && STNIC=n && ULTRA=n && WD80x3=n
>> +	depends on XSURF100=n && ZORRO8390=n
>> +	---help---
>
> Generally I'm not too happy with these changes, they are all very hackish.

I see only one option to address that: rewrite apne.c to include 
lib8390.c directly.

Moving the inb() and outb() redefines into the m68k version of io.h 
(which Geert is likely to veto because of its hackishness) would still 
require a Kconfig hack.

> And in particular this huge complicated Kconfig construct is not
> maintainable at all.

We can trim this down a bit (for reasons I've outlined before):

+if APNE
+config APNE100MBIT
+	bool "PCMCIA NE2000 100MBit support"
+	default n
+	depends on NE2000=n && PCMCIA_AXNET=n
+	depends on PCMCIA_PCNET=n && STNIC=n && ULTRA=n && WD80x3=n

In all honesty, I doubt anyone could ever use the stnic, ultra and wd 
drivers on m68k (Geert?) so these could be omitted as well. Not sure 
pcnet_cs or axnet_cs are possible to use on the Amiga PCMCIA slot, so 
all that remains in practice is the ne driver (which is used on Atari).

Still too ugly?

Cheers,

	Michael

>
> Sorry.
>

  reply	other threads:[~2018-12-21 21:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-19 22:24 [PATCH net-next] Amiga PCMCIA 100 MBit card support ALeX Kazik
2018-12-21  0:10 ` David Miller
2018-12-21 21:30   ` Michael Schmitz [this message]
2018-12-28 20:43     ` David Miller
2018-12-31  9:48       ` Michael Schmitz
2018-12-31 10:47         ` Andrew Lunn
2019-01-04  0:41           ` Michael Schmitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2a960bfa-000a-eb14-814b-476da5c1f5df@gmail.com \
    --to=schmitzmic@gmail.com \
    --cc=alex@kazik.de \
    --cc=davem@davemloft.net \
    --cc=linux-m68k@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rolf.anders@physik.uni-augsburg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).