From: Andreas Schwab <schwab@linux-m68k.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Michael Schmitz <schmitzmic@gmail.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-m68k <linux-m68k@lists.linux-m68k.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH RFC v2] m68k: remove get_fs()/set_fs()
Date: Thu, 08 Jul 2021 09:36:09 +0200 [thread overview]
Message-ID: <87lf6hmf4m.fsf@igel.home> (raw)
In-Reply-To: <CAHk-=wgCp0X4Q=GkDF1j1=_XTq4gA_ZsKUXfkPBeeTJcoS6gwQ@mail.gmail.com> (Linus Torvalds's message of "Wed, 7 Jul 2021 20:01:33 -0700")
On Jul 07 2021, Linus Torvalds wrote:
> Christoph does:
>
> #define __put_user_asm(inst, res, x, ptr, bwl, reg) \
> asm volatile ("\n" \
> "1: #inst."#bwl" %2,%1\n"
> ...
>
> and then uses it with code like
>
> __put_user_asm(MOVES, __pu_err, __pu_val, ptr, b, d);
>
> and
>
> __get_user_asm("move", __gk_err, __gk_dst, __gk_src, u8, b, d);
>
> and the issue is that there's a '#' too many.
>
> The '#' turns the argument into a string,
No, it's inside a string, and the assembler just sees a comment starting
with `#inst.'.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2021-07-08 7:36 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 1:48 [PATCH RFC v2] m68k: remove get_fs()/set_fs() Michael Schmitz
2021-07-08 2:51 ` Linus Torvalds
2021-07-08 3:01 ` Linus Torvalds
2021-07-08 3:37 ` Michael Schmitz
2021-07-08 4:31 ` Christoph Hellwig
2021-07-08 4:33 ` Michael Schmitz
2021-07-08 4:58 ` Christoph Hellwig
2021-07-08 5:48 ` Michael Schmitz
2021-07-08 12:57 ` Christoph Hellwig
2021-07-08 18:20 ` Linus Torvalds
2021-07-09 0:05 ` Michael Schmitz
2021-07-08 19:28 ` Michael Schmitz
2021-07-09 0:31 ` Michael Schmitz
2021-07-09 4:22 ` Christoph Hellwig
2021-07-09 5:47 ` Michael Schmitz
2021-07-09 7:29 ` Geert Uytterhoeven
2021-07-09 8:34 ` Michael Schmitz
2021-07-09 8:53 ` Christoph Hellwig
2021-07-09 9:00 ` Michael Schmitz
2021-07-09 11:20 ` Geert Uytterhoeven
2021-07-09 19:25 ` Michael Schmitz
2021-07-09 19:52 ` Michael Schmitz
2021-07-09 20:03 ` Linus Torvalds
2021-07-09 20:13 ` Linus Torvalds
2021-07-09 19:53 ` Linus Torvalds
2021-07-09 21:08 ` Michael Schmitz
2021-07-09 21:18 ` Linus Torvalds
2021-07-10 2:30 ` Michael Schmitz
2021-07-09 11:35 ` Geert Uytterhoeven
2021-07-08 7:36 ` Andreas Schwab [this message]
2021-07-08 4:28 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lf6hmf4m.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=geert@linux-m68k.org \
--cc=hch@lst.de \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=schmitzmic@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).