From: Linus Torvalds <torvalds@linux-foundation.org>
To: Michael Schmitz <schmitzmic@gmail.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Christoph Hellwig <hch@lst.de>,
linux-m68k <linux-m68k@lists.linux-m68k.org>
Subject: Re: [PATCH RFC v2] m68k: remove get_fs()/set_fs()
Date: Fri, 9 Jul 2021 13:03:22 -0700 [thread overview]
Message-ID: <CAHk-=wgK9tKr4EG9B0YhW28XDUOUTc5-Ds1=pa1wtvFyNbExhw@mail.gmail.com> (raw)
In-Reply-To: <34ba1bc1-9e15-3d14-55ec-a5b4ca118e63@gmail.com>
On Fri, Jul 9, 2021 at 12:52 PM Michael Schmitz <schmitzmic@gmail.com> wrote:
>
> That one got called from sys_llseek+0x5c/0x86
That's the
if (offset >= 0) {
retval = -EFAULT;
if (!copy_to_user(result, &offset, sizeof(offset)))
retval = 0;
}
and it might be worth doing a put_user() for. That would actually
simplify the code to just
if (offset >= 0)
retval = put_user(offset, result);
or something like that.
Except maybe there's some 32-bit architecture that doesn't support
8-byte get/put_user(), which may be why it's a copy_to_user().
I _think_ we made the rule be that everybody had to support 1/2/4/8
byte accesses, but maybe I remember incorrectly.
Linus
next prev parent reply other threads:[~2021-07-09 20:03 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 1:48 [PATCH RFC v2] m68k: remove get_fs()/set_fs() Michael Schmitz
2021-07-08 2:51 ` Linus Torvalds
2021-07-08 3:01 ` Linus Torvalds
2021-07-08 3:37 ` Michael Schmitz
2021-07-08 4:31 ` Christoph Hellwig
2021-07-08 4:33 ` Michael Schmitz
2021-07-08 4:58 ` Christoph Hellwig
2021-07-08 5:48 ` Michael Schmitz
2021-07-08 12:57 ` Christoph Hellwig
2021-07-08 18:20 ` Linus Torvalds
2021-07-09 0:05 ` Michael Schmitz
2021-07-08 19:28 ` Michael Schmitz
2021-07-09 0:31 ` Michael Schmitz
2021-07-09 4:22 ` Christoph Hellwig
2021-07-09 5:47 ` Michael Schmitz
2021-07-09 7:29 ` Geert Uytterhoeven
2021-07-09 8:34 ` Michael Schmitz
2021-07-09 8:53 ` Christoph Hellwig
2021-07-09 9:00 ` Michael Schmitz
2021-07-09 11:20 ` Geert Uytterhoeven
2021-07-09 19:25 ` Michael Schmitz
2021-07-09 19:52 ` Michael Schmitz
2021-07-09 20:03 ` Linus Torvalds [this message]
2021-07-09 20:13 ` Linus Torvalds
2021-07-09 19:53 ` Linus Torvalds
2021-07-09 21:08 ` Michael Schmitz
2021-07-09 21:18 ` Linus Torvalds
2021-07-10 2:30 ` Michael Schmitz
2021-07-09 11:35 ` Geert Uytterhoeven
2021-07-08 7:36 ` Andreas Schwab
2021-07-08 4:28 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wgK9tKr4EG9B0YhW28XDUOUTc5-Ds1=pa1wtvFyNbExhw@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=hch@lst.de \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).