From: Michael Schmitz <schmitzmic@gmail.com>
To: Greg Ungerer <gerg@linux-m68k.org>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux/m68k <linux-m68k@vger.kernel.org>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Andreas Schwab <schwab@linux-m68k.org>
Subject: Re: [PATCH v6 1/2] m68k/kernel - wire up syscall_trace_enter/leave for m68k
Date: Tue, 29 Jun 2021 19:46:09 +1200 [thread overview]
Message-ID: <90b05a3c-47af-c89e-860d-ac0d20edbac0@gmail.com> (raw)
In-Reply-To: <23eb0e8f-a9d1-24b5-2d97-3dbcbd2bfaaa@linux-m68k.org>
Hi Geert, Greg,
no matter - I managed to at least get entry.S to 'compile' for 68000,
even though the final link failed.
I'm reasonably certain that 'ret_from_exception' is the correct branch
target if a syscall is to be skipped, but I'd like to have that double
checked?
Cheers,
Michael
Am 29.06.2021 um 19:35 schrieb Greg Ungerer:
> Hi Michael, Geert,
>
> On 29/6/21 5:31 pm, Geert Uytterhoeven wrote:
>> Hi Michael,
>>
>> On Tue, Jun 29, 2021 at 12:16 AM Michael Schmitz
>> <schmitzmic@gmail.com> wrote:
>>> On 28/06/21 7:25 pm, Geert Uytterhoeven wrote:
>>>> On Thu, Jun 24, 2021 at 2:46 AM Michael Schmitz
>>>> <schmitzmic@gmail.com> wrote:
>>>>> m68k (other than Coldfire) uses syscall_trace for both trace entry
>>>>> and trace exit. Seccomp support requires separate entry points for
>>>>> trace entry and exit which are already provided for Coldfire.
>>>>>
>>>>> Replace syscall_trace by syscall_trace_enter and syscall_trace_leave
>>>>> in preparation for seccomp support. Check return code of
>>>>> syscall_trace_enter(), and skip syscall if -1. Return code will be
>>>>> left at what had been set by ptrace or seccomp (in regs->d0).
>>>>>
>>>>> No regression seen in testing with strace on ARAnyM.
>>>>>
>>>>> Signed-off-by: Michael Schmitz <schmitzmic@gmail.com>
>>>> b
>>>> Thanks for your patch!
>>>>
>>>>> arch/m68k/kernel/entry.S | 8 +++++---
>>>> We need similar changes to arch/m68k/68000/entry.S and
>>>> arch/m68k/coldfire/entry.S
>>>
>>> Do you have a current defconfig for 68000? I've test compiled my patch
>>> with two coldfire defconfigs, but could not find one for m68kclassic ...
>>
>> Unfortunately not.
>> Greg?
>
> Sorry, no, I don't have one.
> Whenever I need to compile for a 68000 target I manually configure one
> ("make menuconfig" and friends).
>
> Would be nice to have one in mainline ;-)
>
> Regards
> Greg
>
next prev parent reply other threads:[~2021-06-29 7:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 0:45 [PATCH v6 0/2] Add kernel seccomp support for m68k Michael Schmitz
2021-06-24 0:45 ` [PATCH v6 1/2] m68k/kernel - wire up syscall_trace_enter/leave " Michael Schmitz
2021-06-28 7:25 ` Geert Uytterhoeven
2021-06-28 20:52 ` Michael Schmitz
2021-06-28 22:16 ` Michael Schmitz
2021-06-29 7:31 ` Geert Uytterhoeven
2021-06-29 7:35 ` Greg Ungerer
2021-06-29 7:46 ` Michael Schmitz [this message]
2021-06-24 0:46 ` [PATCH v6 2/2] m68k: add kernel seccomp support Michael Schmitz
2021-06-28 7:23 ` Geert Uytterhoeven
2021-06-28 20:17 ` Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90b05a3c-47af-c89e-860d-ac0d20edbac0@gmail.com \
--to=schmitzmic@gmail.com \
--cc=geert@linux-m68k.org \
--cc=gerg@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linux-m68k@vger.kernel.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).