linux-m68k.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Schmitz <schmitzmic@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux/m68k <linux-m68k@vger.kernel.org>,
	John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
	Andreas Schwab <schwab@linux-m68k.org>
Subject: Re: [PATCH v6 1/2] m68k/kernel - wire up syscall_trace_enter/leave for m68k
Date: Tue, 29 Jun 2021 10:16:00 +1200	[thread overview]
Message-ID: <aeac601a-a6ff-678b-83dc-48dacb430ec3@gmail.com> (raw)
In-Reply-To: <CAMuHMdWoX=6Yf7MZXR92Q3APYixY5MDM6MW_UUf0DO2+oDkHAQ@mail.gmail.com>

Hi Geert,

On 28/06/21 7:25 pm, Geert Uytterhoeven wrote:
> On Thu, Jun 24, 2021 at 2:46 AM Michael Schmitz <schmitzmic@gmail.com> wrote:
>> m68k (other than Coldfire) uses syscall_trace for both trace entry
>> and trace exit. Seccomp support requires separate entry points for
>> trace entry and exit which are already provided for Coldfire.
>>
>> Replace syscall_trace by syscall_trace_enter and syscall_trace_leave
>> in preparation for seccomp support. Check return code of
>> syscall_trace_enter(), and skip syscall if -1. Return code will be
>> left at what had been set by ptrace or seccomp (in regs->d0).
>>
>> No regression seen in testing with strace on ARAnyM.
>>
>> Signed-off-by: Michael Schmitz <schmitzmic@gmail.com>
> b
> Thanks for your patch!
>
>>   arch/m68k/kernel/entry.S  |  8 +++++---
> We need similar changes to arch/m68k/68000/entry.S and
> arch/m68k/coldfire/entry.S

Do you have a current defconfig for 68000? I've test compiled my patch 
with two coldfire defconfigs, but could not find one for m68kclassic ...

Cheers,

     Michael


>
>>   arch/m68k/kernel/ptrace.c | 17 -----------------
>>   2 files changed, 5 insertions(+), 20 deletions(-)
> Gr{oetje,eeting}s,
>
>                          Geert
>

  parent reply	other threads:[~2021-06-28 22:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-24  0:45 [PATCH v6 0/2] Add kernel seccomp support for m68k Michael Schmitz
2021-06-24  0:45 ` [PATCH v6 1/2] m68k/kernel - wire up syscall_trace_enter/leave " Michael Schmitz
2021-06-28  7:25   ` Geert Uytterhoeven
2021-06-28 20:52     ` Michael Schmitz
2021-06-28 22:16     ` Michael Schmitz [this message]
2021-06-29  7:31       ` Geert Uytterhoeven
2021-06-29  7:35         ` Greg Ungerer
2021-06-29  7:46           ` Michael Schmitz
2021-06-24  0:46 ` [PATCH v6 2/2] m68k: add kernel seccomp support Michael Schmitz
2021-06-28  7:23   ` Geert Uytterhoeven
2021-06-28 20:17     ` Michael Schmitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aeac601a-a6ff-678b-83dc-48dacb430ec3@gmail.com \
    --to=schmitzmic@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=linux-m68k@vger.kernel.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).