* [PATCH v3 resend 01/15] mm: add setup_initial_init_mm() helper [not found] <20210608083418.137226-1-wangkefeng.wang@huawei.com> @ 2021-06-08 8:34 ` Kefeng Wang 2021-06-08 14:53 ` Souptick Joarder 2021-06-08 8:34 ` [PATCH v3 resend 07/15] m68k: convert to setup_initial_init_mm() Kefeng Wang 1 sibling, 1 reply; 5+ messages in thread From: Kefeng Wang @ 2021-06-08 8:34 UTC (permalink / raw) To: Andrew Morton, linux-kernel Cc: linux-mm, Kefeng Wang, linux-snps-arc, linux-arm-kernel, linux-csky, uclinux-h8-devel, linux-m68k, openrisc, linuxppc-dev, linux-riscv, linux-sh, linux-s390, x86 Add setup_initial_init_mm() helper to setup kernel text, data and brk. Cc: linux-snps-arc@lists.infradead.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-csky@vger.kernel.org Cc: uclinux-h8-devel@lists.sourceforge.jp Cc: linux-m68k@lists.linux-m68k.org Cc: openrisc@lists.librecores.org Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-riscv@lists.infradead.org Cc: linux-sh@vger.kernel.org Cc: linux-s390@vger.kernel.org Cc: x86@kernel.org Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> --- include/linux/mm.h | 3 +++ mm/init-mm.c | 9 +++++++++ 2 files changed, 12 insertions(+) diff --git a/include/linux/mm.h b/include/linux/mm.h index c274f75efcf9..02aa057540b7 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -244,6 +244,9 @@ int __add_to_page_cache_locked(struct page *page, struct address_space *mapping, #define lru_to_page(head) (list_entry((head)->prev, struct page, lru)) +void setup_initial_init_mm(void *start_code, void *end_code, + void *end_data, void *brk); + /* * Linux kernel virtual memory manager primitives. * The idea being to have a "virtual" mm in the same way diff --git a/mm/init-mm.c b/mm/init-mm.c index 153162669f80..b4a6f38fb51d 100644 --- a/mm/init-mm.c +++ b/mm/init-mm.c @@ -40,3 +40,12 @@ struct mm_struct init_mm = { .cpu_bitmap = CPU_BITS_NONE, INIT_MM_CONTEXT(init_mm) }; + +void setup_initial_init_mm(void *start_code, void *end_code, + void *end_data, void *brk) +{ + init_mm.start_code = (unsigned long)start_code; + init_mm.end_code = (unsigned long)end_code; + init_mm.end_data = (unsigned long)end_data; + init_mm.brk = (unsigned long)brk; +} -- 2.26.2 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3 resend 01/15] mm: add setup_initial_init_mm() helper 2021-06-08 8:34 ` [PATCH v3 resend 01/15] mm: add setup_initial_init_mm() helper Kefeng Wang @ 2021-06-08 14:53 ` Souptick Joarder 2021-06-08 14:57 ` Christophe Leroy 0 siblings, 1 reply; 5+ messages in thread From: Souptick Joarder @ 2021-06-08 14:53 UTC (permalink / raw) To: Kefeng Wang Cc: Andrew Morton, linux-kernel, Linux-MM, linux-snps-arc, linux-arm-kernel, linux-csky, uclinux-h8-devel, linux-m68k, openrisc, linuxppc-dev, linux-riscv, linux-sh, linux-s390, X86 ML On Tue, Jun 8, 2021 at 1:56 PM Kefeng Wang <wangkefeng.wang@huawei.com> wrote: > > Add setup_initial_init_mm() helper to setup kernel text, > data and brk. > > Cc: linux-snps-arc@lists.infradead.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-csky@vger.kernel.org > Cc: uclinux-h8-devel@lists.sourceforge.jp > Cc: linux-m68k@lists.linux-m68k.org > Cc: openrisc@lists.librecores.org > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-riscv@lists.infradead.org > Cc: linux-sh@vger.kernel.org > Cc: linux-s390@vger.kernel.org > Cc: x86@kernel.org > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> > --- > include/linux/mm.h | 3 +++ > mm/init-mm.c | 9 +++++++++ > 2 files changed, 12 insertions(+) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index c274f75efcf9..02aa057540b7 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -244,6 +244,9 @@ int __add_to_page_cache_locked(struct page *page, struct address_space *mapping, > > #define lru_to_page(head) (list_entry((head)->prev, struct page, lru)) > > +void setup_initial_init_mm(void *start_code, void *end_code, > + void *end_data, void *brk); > + Gentle query -> is there any limitation to add inline functions in setup_arch() functions ? > /* > * Linux kernel virtual memory manager primitives. > * The idea being to have a "virtual" mm in the same way > diff --git a/mm/init-mm.c b/mm/init-mm.c > index 153162669f80..b4a6f38fb51d 100644 > --- a/mm/init-mm.c > +++ b/mm/init-mm.c > @@ -40,3 +40,12 @@ struct mm_struct init_mm = { > .cpu_bitmap = CPU_BITS_NONE, > INIT_MM_CONTEXT(init_mm) > }; > + > +void setup_initial_init_mm(void *start_code, void *end_code, > + void *end_data, void *brk) > +{ > + init_mm.start_code = (unsigned long)start_code; > + init_mm.end_code = (unsigned long)end_code; > + init_mm.end_data = (unsigned long)end_data; > + init_mm.brk = (unsigned long)brk; > +} > -- > 2.26.2 > > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 resend 01/15] mm: add setup_initial_init_mm() helper 2021-06-08 14:53 ` Souptick Joarder @ 2021-06-08 14:57 ` Christophe Leroy 2021-06-08 15:14 ` Souptick Joarder 0 siblings, 1 reply; 5+ messages in thread From: Christophe Leroy @ 2021-06-08 14:57 UTC (permalink / raw) To: Souptick Joarder, Kefeng Wang Cc: uclinux-h8-devel, linux-s390, linux-sh, X86 ML, linux-kernel, linux-csky, Linux-MM, linux-m68k, openrisc, Andrew Morton, linux-snps-arc, linuxppc-dev, linux-riscv, linux-arm-kernel Le 08/06/2021 à 16:53, Souptick Joarder a écrit : > On Tue, Jun 8, 2021 at 1:56 PM Kefeng Wang <wangkefeng.wang@huawei.com> wrote: >> >> Add setup_initial_init_mm() helper to setup kernel text, >> data and brk. >> >> Cc: linux-snps-arc@lists.infradead.org >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-csky@vger.kernel.org >> Cc: uclinux-h8-devel@lists.sourceforge.jp >> Cc: linux-m68k@lists.linux-m68k.org >> Cc: openrisc@lists.librecores.org >> Cc: linuxppc-dev@lists.ozlabs.org >> Cc: linux-riscv@lists.infradead.org >> Cc: linux-sh@vger.kernel.org >> Cc: linux-s390@vger.kernel.org >> Cc: x86@kernel.org >> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> >> --- >> include/linux/mm.h | 3 +++ >> mm/init-mm.c | 9 +++++++++ >> 2 files changed, 12 insertions(+) >> >> diff --git a/include/linux/mm.h b/include/linux/mm.h >> index c274f75efcf9..02aa057540b7 100644 >> --- a/include/linux/mm.h >> +++ b/include/linux/mm.h >> @@ -244,6 +244,9 @@ int __add_to_page_cache_locked(struct page *page, struct address_space *mapping, >> >> #define lru_to_page(head) (list_entry((head)->prev, struct page, lru)) >> >> +void setup_initial_init_mm(void *start_code, void *end_code, >> + void *end_data, void *brk); >> + > > Gentle query -> is there any limitation to add inline functions in > setup_arch() functions ? Kefeng just followed comment from Mike I guess, see https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20210604070633.32363-2-wangkefeng.wang@huawei.com/#2696253 Christophe ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 resend 01/15] mm: add setup_initial_init_mm() helper 2021-06-08 14:57 ` Christophe Leroy @ 2021-06-08 15:14 ` Souptick Joarder 0 siblings, 0 replies; 5+ messages in thread From: Souptick Joarder @ 2021-06-08 15:14 UTC (permalink / raw) To: Christophe Leroy Cc: Kefeng Wang, uclinux-h8-devel, linux-s390, linux-sh, X86 ML, linux-kernel, linux-csky, Linux-MM, linux-m68k, openrisc, Andrew Morton, linux-snps-arc, linuxppc-dev, linux-riscv, linux-arm-kernel On Tue, Jun 8, 2021 at 8:27 PM Christophe Leroy <christophe.leroy@csgroup.eu> wrote: > > > > Le 08/06/2021 à 16:53, Souptick Joarder a écrit : > > On Tue, Jun 8, 2021 at 1:56 PM Kefeng Wang <wangkefeng.wang@huawei.com> wrote: > >> > >> Add setup_initial_init_mm() helper to setup kernel text, > >> data and brk. > >> > >> Cc: linux-snps-arc@lists.infradead.org > >> Cc: linux-arm-kernel@lists.infradead.org > >> Cc: linux-csky@vger.kernel.org > >> Cc: uclinux-h8-devel@lists.sourceforge.jp > >> Cc: linux-m68k@lists.linux-m68k.org > >> Cc: openrisc@lists.librecores.org > >> Cc: linuxppc-dev@lists.ozlabs.org > >> Cc: linux-riscv@lists.infradead.org > >> Cc: linux-sh@vger.kernel.org > >> Cc: linux-s390@vger.kernel.org > >> Cc: x86@kernel.org > >> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> > >> --- > >> include/linux/mm.h | 3 +++ > >> mm/init-mm.c | 9 +++++++++ > >> 2 files changed, 12 insertions(+) > >> > >> diff --git a/include/linux/mm.h b/include/linux/mm.h > >> index c274f75efcf9..02aa057540b7 100644 > >> --- a/include/linux/mm.h > >> +++ b/include/linux/mm.h > >> @@ -244,6 +244,9 @@ int __add_to_page_cache_locked(struct page *page, struct address_space *mapping, > >> > >> #define lru_to_page(head) (list_entry((head)->prev, struct page, lru)) > >> > >> +void setup_initial_init_mm(void *start_code, void *end_code, > >> + void *end_data, void *brk); > >> + > > > > Gentle query -> is there any limitation to add inline functions in > > setup_arch() functions ? > > Kefeng just followed comment from Mike I guess, see > https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20210604070633.32363-2-wangkefeng.wang@huawei.com/#2696253 Ok. > > Christophe > ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v3 resend 07/15] m68k: convert to setup_initial_init_mm() [not found] <20210608083418.137226-1-wangkefeng.wang@huawei.com> 2021-06-08 8:34 ` [PATCH v3 resend 01/15] mm: add setup_initial_init_mm() helper Kefeng Wang @ 2021-06-08 8:34 ` Kefeng Wang 1 sibling, 0 replies; 5+ messages in thread From: Kefeng Wang @ 2021-06-08 8:34 UTC (permalink / raw) To: Andrew Morton, linux-kernel Cc: linux-mm, Kefeng Wang, Greg Ungerer, Geert Uytterhoeven, linux-m68k Use setup_initial_init_mm() helper to simplify code. Acked-by: Greg Ungerer <gerg@linux-m68k.org> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Greg Ungerer <gerg@linux-m68k.org> Cc: linux-m68k@lists.linux-m68k.org Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> --- arch/m68k/kernel/setup_mm.c | 5 +---- arch/m68k/kernel/setup_no.c | 5 +---- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/arch/m68k/kernel/setup_mm.c b/arch/m68k/kernel/setup_mm.c index 017bac3aab80..4b51bfd38e5f 100644 --- a/arch/m68k/kernel/setup_mm.c +++ b/arch/m68k/kernel/setup_mm.c @@ -258,10 +258,7 @@ void __init setup_arch(char **cmdline_p) } } - init_mm.start_code = PAGE_OFFSET; - init_mm.end_code = (unsigned long)_etext; - init_mm.end_data = (unsigned long)_edata; - init_mm.brk = (unsigned long)_end; + setup_initial_init_mm((void *)PAGE_OFFSET, _etext, _edata, _end); #if defined(CONFIG_BOOTPARAM) strncpy(m68k_command_line, CONFIG_BOOTPARAM_STRING, CL_SIZE); diff --git a/arch/m68k/kernel/setup_no.c b/arch/m68k/kernel/setup_no.c index d1b7988efc91..5e4104f07a44 100644 --- a/arch/m68k/kernel/setup_no.c +++ b/arch/m68k/kernel/setup_no.c @@ -87,10 +87,7 @@ void __init setup_arch(char **cmdline_p) memory_start = PAGE_ALIGN(_ramstart); memory_end = _ramend; - init_mm.start_code = (unsigned long) &_stext; - init_mm.end_code = (unsigned long) &_etext; - init_mm.end_data = (unsigned long) &_edata; - init_mm.brk = (unsigned long) 0; + setup_initial_init_mm(_stext, _etext, _edata, NULL); config_BSP(&command_line[0], sizeof(command_line)); -- 2.26.2 ^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-06-08 15:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210608083418.137226-1-wangkefeng.wang@huawei.com>
2021-06-08 8:34 ` [PATCH v3 resend 01/15] mm: add setup_initial_init_mm() helper Kefeng Wang
2021-06-08 14:53 ` Souptick Joarder
2021-06-08 14:57 ` Christophe Leroy
2021-06-08 15:14 ` Souptick Joarder
2021-06-08 8:34 ` [PATCH v3 resend 07/15] m68k: convert to setup_initial_init_mm() Kefeng Wang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).