linux-m68k.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Pascal Terjan <pterjan@google.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>,
	"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
	linux-m68k <linux-m68k@lists.linux-m68k.org>
Subject: Re: [PATCH v3] Remove every trace of SERIAL_MAGIC
Date: Tue, 5 Nov 2019 09:42:49 +0100	[thread overview]
Message-ID: <CAMuHMdUm+s4UaBrtxvXaLg1EUmsoYYG=6JvnWzC0ivbyzdMBZw@mail.gmail.com> (raw)
In-Reply-To: <20191104193525.229055-1-pterjan@google.com>

Hi Pascal,

On Mon, Nov 4, 2019 at 8:35 PM Pascal Terjan <pterjan@google.com> wrote:
> This means removing support for some debugging code in amiserial.c
> (SERIAL_PARANOIA_CHECK option), which was checking a magic field which
> doesn't currently exist in the struct. That code hasn't built at least
> since git.
>
> Removing the definition from the header is safe anyway as that code was
> from another driver and not including it.
>
> Signed-off-by: Pascal Terjan <pterjan@google.com>

Thanks for your patch!

> --- a/drivers/tty/amiserial.c
> +++ b/drivers/tty/amiserial.c
> @@ -23,17 +23,12 @@
>   */
>
>  /*
> - * Serial driver configuration section.  Here are the various options:
> + * Serial driver configuration section.
>   *
> - * SERIAL_PARANOIA_CHECK
> - *             Check the magic number for the async_structure where
> - *             ever possible.
>   */

You might as well drop the whole comment block, as no options are left.

With that fixed:
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

BTW, there's a similar serial_paranoia_check() in drivers/tty/cyclades.c,
which is active, but doesn't serve much purpose, IMHO.

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

       reply	other threads:[~2019-11-05  8:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20191004132256.GA715053@kroah.com>
     [not found] ` <20191104193525.229055-1-pterjan@google.com>
2019-11-05  8:42   ` Geert Uytterhoeven [this message]
2019-11-05 19:27     ` [PATCH v4] " Pascal Terjan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdUm+s4UaBrtxvXaLg1EUmsoYYG=6JvnWzC0ivbyzdMBZw@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=pterjan@google.com \
    --subject='Re: [PATCH v3] Remove every trace of SERIAL_MAGIC' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).