Re: [PATCH v3] Remove every trace of SERIAL_MAGIC

[Geert Uytterhoeven <geert@linux-m68k.org>]

Hi Pascal,

On Mon, Nov 4, 2019 at 8:35 PM Pascal Terjan <pterjan@google.com> wrote:
> This means removing support for some debugging code in amiserial.c
> (SERIAL_PARANOIA_CHECK option), which was checking a magic field which
> doesn't currently exist in the struct. That code hasn't built at least
> since git.
>
> Removing the definition from the header is safe anyway as that code was
> from another driver and not including it.
>
> Signed-off-by: Pascal Terjan <pterjan@google.com>

Thanks for your patch!

> --- a/drivers/tty/amiserial.c
> +++ b/drivers/tty/amiserial.c
> @@ -23,17 +23,12 @@
>   */
>
>  /*
> - * Serial driver configuration section.  Here are the various options:
> + * Serial driver configuration section.
>   *
> - * SERIAL_PARANOIA_CHECK
> - *             Check the magic number for the async_structure where
> - *             ever possible.
>   */

You might as well drop the whole comment block, as no options are left.

With that fixed:
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

BTW, there's a similar serial_paranoia_check() in drivers/tty/cyclades.c,
which is active, but doesn't serve much purpose, IMHO.

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds