From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Christian Brauner <christian.brauner@ubuntu.com>
Cc: Kars de Jong <jongk@linux-m68k.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Linux/m68k" <linux-m68k@vger.kernel.org>,
"Amanieu d'Antras" <amanieu@gmail.com>
Subject: Re: [PATCH] m68k: Wire up clone3() syscall
Date: Mon, 13 Jan 2020 11:31:29 +0100 [thread overview]
Message-ID: <CAMuHMdUmP4moBKAURp61E=K0-6Jiwi1OFayKS0h-yT17+mKCgQ@mail.gmail.com> (raw)
In-Reply-To: <20200113101714.75v5gmg3rb5tlhze@wittgenstein>
Hi Christian,
On Mon, Jan 13, 2020 at 11:18 AM Christian Brauner
<christian.brauner@ubuntu.com> wrote:
> On Mon, Jan 13, 2020 at 10:34:35AM +0100, Geert Uytterhoeven wrote:
> > On Mon, Jan 13, 2020 at 10:18 AM Christian Brauner
> > <christian.brauner@ubuntu.com> wrote:
> > > On Mon, Jan 13, 2020 at 10:10:26AM +0100, Geert Uytterhoeven wrote:
> > > > On Sun, Jan 12, 2020 at 5:06 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > > > > On Sun, Nov 24, 2019 at 8:52 PM Kars de Jong <jongk@linux-m68k.org> wrote:
> > > > > > Wire up the clone3() syscall for m68k. The special entry point is done in
> > > > > > assembler as was done for clone() as well. This is needed because all
> > > > > > registers need to be saved. The C wrapper then calls the generic
> > > > > > sys_clone3() with the correct arguments.
> > > > > >
> > > > > > Tested on A1200 using the simple test program from:
> > > > > >
> > > > > > https://lore.kernel.org/lkml/20190716130631.tohj4ub54md25dys@brauner.io/
> > > > > >
> > > > > > Cc: linux-m68k@vger.kernel.org
> > > > > > Signed-off-by: Kars de Jong <jongk@linux-m68k.org>
> > > > >
> > > > > Thanks, applied and queued for v5.6.
> > > >
> > > > Which is now broken because of commit dd499f7a7e342702 ("clone3: ensure
> > > > copy_thread_tls is implemented") in v5.5-rc6 :-(
> > >
> > > Sorry, just for clarification what and how is it broken by
> > > dd499f7a7e342702 ("clone3: ensure > copy_thread_tls is implemented")
> > > ?
> >
> > Because m68k does not implement copy_thread_tls() yet, and doesn't
> > select HAVE_COPY_THREAD_TLS yet.
>
> Oh right, sorry. I forgot that m68k has a patchset to enable clone3() up
> for merging. I should've remembered that and warned you that we will
> have to require copy_thread_tls() going forward. I hope the merge is
> explanatory enough why we're doing it this way.
Yeah, an early warning would have been nice...
> > Looking into fixing that...
>
> Thank you! Much appreciated!
Patch sent.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
prev parent reply other threads:[~2020-01-13 10:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-24 19:52 [PATCH] m68k: Wire up clone3() syscall Kars de Jong
2019-11-25 9:12 ` Geert Uytterhoeven
2019-11-26 14:41 ` Christian Brauner
2019-11-26 15:29 ` Kars de Jong
2019-12-15 16:48 ` Geert Uytterhoeven
2019-12-15 17:01 ` John Paul Adrian Glaubitz
2019-12-15 20:06 ` Geert Uytterhoeven
2019-12-16 10:31 ` Christian Brauner
2019-12-18 9:57 ` Kars de Jong
2020-01-12 16:06 ` Geert Uytterhoeven
2020-01-13 9:10 ` Geert Uytterhoeven
2020-01-13 9:18 ` Christian Brauner
2020-01-13 9:34 ` Geert Uytterhoeven
2020-01-13 10:17 ` Christian Brauner
2020-01-13 10:31 ` Geert Uytterhoeven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdUmP4moBKAURp61E=K0-6Jiwi1OFayKS0h-yT17+mKCgQ@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=amanieu@gmail.com \
--cc=christian.brauner@ubuntu.com \
--cc=jongk@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).