linux-m68k.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] m68k: remove meaningless $(OS_OBJS)
@ 2021-03-31 14:43 Masahiro Yamada
  2021-03-31 14:43 ` [PATCH 2/2] m68k: remove meaningless EXTRA_LDFLAGS Masahiro Yamada
  2021-03-31 14:59 ` [PATCH 1/2] m68k: remove meaningless $(OS_OBJS) Geert Uytterhoeven
  0 siblings, 2 replies; 4+ messages in thread
From: Masahiro Yamada @ 2021-03-31 14:43 UTC (permalink / raw)
  To: Geert Uytterhoeven, linux-m68k; +Cc: Masahiro Yamada, linux-kernel

'git grep OS_OBJS' hits only this line. $(OS_OBJS) is just empty.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 arch/m68k/fpsp040/Makefile | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/m68k/fpsp040/Makefile b/arch/m68k/fpsp040/Makefile
index aab04d372ae7..5537807457fb 100644
--- a/arch/m68k/fpsp040/Makefile
+++ b/arch/m68k/fpsp040/Makefile
@@ -12,5 +12,3 @@ obj-y    := bindec.o binstr.o decbin.o do_func.o gen_except.o get_op.o \
 	    x_unfl.o x_unimp.o x_unsupp.o bugfix.o skeleton.o
 
 EXTRA_LDFLAGS := -x
-
-$(OS_OBJS): fpsp.h
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] m68k: remove meaningless EXTRA_LDFLAGS
  2021-03-31 14:43 [PATCH 1/2] m68k: remove meaningless $(OS_OBJS) Masahiro Yamada
@ 2021-03-31 14:43 ` Masahiro Yamada
  2021-03-31 15:01   ` Geert Uytterhoeven
  2021-03-31 14:59 ` [PATCH 1/2] m68k: remove meaningless $(OS_OBJS) Geert Uytterhoeven
  1 sibling, 1 reply; 4+ messages in thread
From: Masahiro Yamada @ 2021-03-31 14:43 UTC (permalink / raw)
  To: Geert Uytterhoeven, linux-m68k; +Cc: Masahiro Yamada, linux-kernel

These two Makefiles contain only built-in objects (i.e. obj-y), which
are collected by $(AR) into a thin-archive.

EXTRA_LDFLAGS is meaningless because $(LD) is not used here.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 arch/m68k/fpsp040/Makefile  | 2 --
 arch/m68k/ifpsp060/Makefile | 2 --
 2 files changed, 4 deletions(-)

diff --git a/arch/m68k/fpsp040/Makefile b/arch/m68k/fpsp040/Makefile
index 5537807457fb..834ae9471b88 100644
--- a/arch/m68k/fpsp040/Makefile
+++ b/arch/m68k/fpsp040/Makefile
@@ -10,5 +10,3 @@ obj-y    := bindec.o binstr.o decbin.o do_func.o gen_except.o get_op.o \
 	    ssin.o ssinh.o stan.o stanh.o sto_res.o stwotox.o tbldo.o util.o \
 	    x_bsun.o x_fline.o x_operr.o x_ovfl.o x_snan.o x_store.o \
 	    x_unfl.o x_unimp.o x_unsupp.o bugfix.o skeleton.o
-
-EXTRA_LDFLAGS := -x
diff --git a/arch/m68k/ifpsp060/Makefile b/arch/m68k/ifpsp060/Makefile
index 43b435049452..56b530a96c2f 100644
--- a/arch/m68k/ifpsp060/Makefile
+++ b/arch/m68k/ifpsp060/Makefile
@@ -5,5 +5,3 @@
 # for more details.
 
 obj-y := fskeleton.o iskeleton.o os.o
-
-EXTRA_LDFLAGS := -x
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] m68k: remove meaningless $(OS_OBJS)
  2021-03-31 14:43 [PATCH 1/2] m68k: remove meaningless $(OS_OBJS) Masahiro Yamada
  2021-03-31 14:43 ` [PATCH 2/2] m68k: remove meaningless EXTRA_LDFLAGS Masahiro Yamada
@ 2021-03-31 14:59 ` Geert Uytterhoeven
  1 sibling, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2021-03-31 14:59 UTC (permalink / raw)
  To: Masahiro Yamada; +Cc: linux-m68k, Linux Kernel Mailing List

On Wed, Mar 31, 2021 at 4:44 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
> 'git grep OS_OBJS' hits only this line. $(OS_OBJS) is just empty.

Indeed. All other users were removed in 2002.

> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
i.e. will queue in the m68k for-v5.13 branch.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] m68k: remove meaningless EXTRA_LDFLAGS
  2021-03-31 14:43 ` [PATCH 2/2] m68k: remove meaningless EXTRA_LDFLAGS Masahiro Yamada
@ 2021-03-31 15:01   ` Geert Uytterhoeven
  0 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2021-03-31 15:01 UTC (permalink / raw)
  To: Masahiro Yamada; +Cc: linux-m68k, Linux Kernel Mailing List

On Wed, Mar 31, 2021 at 4:44 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
> These two Makefiles contain only built-in objects (i.e. obj-y), which
> are collected by $(AR) into a thin-archive.
>
> EXTRA_LDFLAGS is meaningless because $(LD) is not used here.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
i.e. will queue in the m68k for-v5.13 branch.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-03-31 15:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-31 14:43 [PATCH 1/2] m68k: remove meaningless $(OS_OBJS) Masahiro Yamada
2021-03-31 14:43 ` [PATCH 2/2] m68k: remove meaningless EXTRA_LDFLAGS Masahiro Yamada
2021-03-31 15:01   ` Geert Uytterhoeven
2021-03-31 14:59 ` [PATCH 1/2] m68k: remove meaningless $(OS_OBJS) Geert Uytterhoeven

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).