* [PATCH] m68k/mac: Fixed duplicate "in" in comments.
@ 2022-07-20 10:53 Xin Gao
2022-07-20 17:37 ` Geert Uytterhoeven
0 siblings, 1 reply; 2+ messages in thread
From: Xin Gao @ 2022-07-20 10:53 UTC (permalink / raw)
To: funaho, geert; +Cc: linux-m68k, linux-kernel, Xin Gao
Fixed duplicate "in" in comments.
Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
---
arch/m68k/mac/misc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/m68k/mac/misc.c b/arch/m68k/mac/misc.c
index 4fab34791758..29a4cb46af01 100644
--- a/arch/m68k/mac/misc.c
+++ b/arch/m68k/mac/misc.c
@@ -126,7 +126,7 @@ static void via_rtc_send(__u8 data)
reg = via1[vBufB] & ~(VIA1B_vRTCClk | VIA1B_vRTCData);
- /* The bits of the byte go in in MSB order */
+ /* The bits of the byte go in MSB order */
for (i = 0 ; i < 8 ; i++) {
bit = data & 0x80? 1 : 0;
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] m68k/mac: Fixed duplicate "in" in comments.
2022-07-20 10:53 [PATCH] m68k/mac: Fixed duplicate "in" in comments Xin Gao
@ 2022-07-20 17:37 ` Geert Uytterhoeven
0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2022-07-20 17:37 UTC (permalink / raw)
To: Xin Gao; +Cc: Joshua Thompson, linux-m68k, Linux Kernel Mailing List
Hi Xin,
On Wed, Jul 20, 2022 at 12:55 PM Xin Gao <gaoxin@cdjrlc.com> wrote:
> Fixed duplicate "in" in comments.
>
> Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
Thanks for your patch!
> --- a/arch/m68k/mac/misc.c
> +++ b/arch/m68k/mac/misc.c
> @@ -126,7 +126,7 @@ static void via_rtc_send(__u8 data)
>
> reg = via1[vBufB] & ~(VIA1B_vRTCClk | VIA1B_vRTCData);
>
> - /* The bits of the byte go in in MSB order */
> + /* The bits of the byte go in MSB order */
The original was correct.
Ask yourself the question: "How should the bits go in?"
"In MSB order".
>
> for (i = 0 ; i < 8 ; i++) {
> bit = data & 0x80? 1 : 0;
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-20 17:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-20 10:53 [PATCH] m68k/mac: Fixed duplicate "in" in comments Xin Gao
2022-07-20 17:37 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).