archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <>
To: Linus Walleij <>
Cc: Michal Simek <>,
	Linux/m68k <>,
	Linux Kernel Mailing List <>,
	Michal Simek <>, Rob Herring <>,
	Thomas Gleixner <>,
	Philippe Ombredanne <>,
	U-Boot Mailing List <>,
	Neil Armstrong <>,
	Kate Stewart <>,
	Greg KH <>,
	Matthias Brugger <>,
	Daniel Lezcano <>
Subject: Re: [PATCH] microblaze: Remove architecture heart beat code
Date: Mon, 11 Jun 2018 10:52:04 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Linus,

On Mon, Jun 11, 2018 at 10:47 AM Linus Walleij <> wrote:
> On Mon, Jun 11, 2018 at 8:09 AM, Michal Simek <> wrote:
> > There is no reason to keep this gpio based code in architecture. Use
> > ledtrig-heartbeat.c instead which is much more flexible then this
> > ancient code.
> >
> > Signed-off-by: Michal Simek <>
> Reviewed-by: Linus Walleij <>
> Maybe the arch maintainers will complain that the corresponding
> new heartbeat code is not put in place in the same patch, but I
> think the change is so much overdue that I don't see why they
> can't do that themselves if they have interest in it.
> BTW: m68k has the same kind of luggage, in the middle of it
> timekeeping code:
> arch/m68k/kernel/time.c

Fixing that means converting m68k to GPIO first, which would take lots of
heartbeats ;-)



Geert Uytterhoeven -- There's lots of Linux beyond ia32 --

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

      reply	other threads:[~2018-06-11  8:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
2018-06-11  8:46 ` [PATCH] microblaze: Remove architecture heart beat code Linus Walleij
2018-06-11  8:52   ` Geert Uytterhoeven [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).