* Re: [PATCH] mm:%Lx is non-standard C
[not found] <20220716161022.16902-1-dengshaomin@cdjrlc.com>
@ 2022-07-17 9:26 ` Geert Uytterhoeven
2022-07-17 9:42 ` Andreas Schwab
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2022-07-17 9:26 UTC (permalink / raw)
To: dengshaomin; +Cc: Sam Creasey, linux-m68k
CC linux-m68k.
On Sat, Jul 16, 2022 at 6:10 PM shaom Deng <dengshaomin@cdjrlc.com> wrote:
> replace %Lx with %lx, because %Lx is not standard
>
> Signed-off-by: shaom Deng <dengshaomin@cdjrlc.com>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
i.e. will queue in the m68k for-v5.20 branch.
> --- a/arch/m68k/sun3/sun3dvma.c
> +++ b/arch/m68k/sun3/sun3dvma.c
> @@ -77,7 +77,7 @@ static void print_use(void)
> pr_info("%d entries in use total\n", j);
>
> pr_info("allocation/free calls: %lu/%lu\n", dvma_allocs, dvma_frees);
> - pr_info("allocation/free bytes: %Lx/%Lx\n", dvma_alloc_bytes,
> + pr_info("allocation/free bytes: %lx/%lx\n", dvma_alloc_bytes,
> dvma_free_bytes);
> }
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm:%Lx is non-standard C
2022-07-17 9:26 ` [PATCH] mm:%Lx is non-standard C Geert Uytterhoeven
@ 2022-07-17 9:42 ` Andreas Schwab
2022-07-17 10:19 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Schwab @ 2022-07-17 9:42 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: dengshaomin, Sam Creasey, linux-m68k
On Jul 17 2022, Geert Uytterhoeven wrote:
> CC linux-m68k.
>
> On Sat, Jul 16, 2022 at 6:10 PM shaom Deng <dengshaomin@cdjrlc.com> wrote:
>> replace %Lx with %lx, because %Lx is not standard
>>
>> Signed-off-by: shaom Deng <dengshaomin@cdjrlc.com>
>
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
> i.e. will queue in the m68k for-v5.20 branch.
>
>> --- a/arch/m68k/sun3/sun3dvma.c
>> +++ b/arch/m68k/sun3/sun3dvma.c
>> @@ -77,7 +77,7 @@ static void print_use(void)
>> pr_info("%d entries in use total\n", j);
>>
>> pr_info("allocation/free calls: %lu/%lu\n", dvma_allocs, dvma_frees);
>> - pr_info("allocation/free bytes: %Lx/%Lx\n", dvma_alloc_bytes,
>> + pr_info("allocation/free bytes: %lx/%lx\n", dvma_alloc_bytes,
>> dvma_free_bytes);
Does that actually work? The L modifier is equivalent to `ll', not `l',
and dvma_alloc_bytes and dvma_free_bytes are in fact of type unsigned
long long.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm:%Lx is non-standard C
2022-07-17 9:42 ` Andreas Schwab
@ 2022-07-17 10:19 ` Geert Uytterhoeven
0 siblings, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2022-07-17 10:19 UTC (permalink / raw)
To: Andreas Schwab; +Cc: dengshaomin, Sam Creasey, linux-m68k
On Sun, Jul 17, 2022 at 12:03 PM Andreas Schwab <schwab@linux-m68k.org> wrote:
> On Jul 17 2022, Geert Uytterhoeven wrote:
> > CC linux-m68k.
> >
> > On Sat, Jul 16, 2022 at 6:10 PM shaom Deng <dengshaomin@cdjrlc.com> wrote:
> >> replace %Lx with %lx, because %Lx is not standard
> >>
> >> Signed-off-by: shaom Deng <dengshaomin@cdjrlc.com>
> >
> > Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > i.e. will queue in the m68k for-v5.20 branch.
> >
> >> --- a/arch/m68k/sun3/sun3dvma.c
> >> +++ b/arch/m68k/sun3/sun3dvma.c
> >> @@ -77,7 +77,7 @@ static void print_use(void)
> >> pr_info("%d entries in use total\n", j);
> >>
> >> pr_info("allocation/free calls: %lu/%lu\n", dvma_allocs, dvma_frees);
> >> - pr_info("allocation/free bytes: %Lx/%Lx\n", dvma_alloc_bytes,
> >> + pr_info("allocation/free bytes: %lx/%lx\n", dvma_alloc_bytes,
> >> dvma_free_bytes);
>
> Does that actually work? The L modifier is equivalent to `ll', not `l',
> and dvma_alloc_bytes and dvma_free_bytes are in fact of type unsigned
> long long.
You're absolutely right. More coffee needed....
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-17 10:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220716161022.16902-1-dengshaomin@cdjrlc.com>
2022-07-17 9:26 ` [PATCH] mm:%Lx is non-standard C Geert Uytterhoeven
2022-07-17 9:42 ` Andreas Schwab
2022-07-17 10:19 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).