From: Eero Tamminen <oak@helsinkinet.fi>
To: linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org
Subject: Re: [PATCH printk v3 24/40] tty: nfcon: use console_is_registered()
Date: Thu, 10 Nov 2022 19:50:04 +0200 [thread overview]
Message-ID: <a6deb895-342c-ca32-fa3c-39d6c826d70c@helsinkinet.fi> (raw)
In-Reply-To: <87cz9u6gfd.fsf@jogness.linutronix.de>
Hi,
On 10.11.2022 16.19, John Ogness wrote:
> On 2022-11-10, Petr Mladek <pmladek@suse.com> wrote:
...
>>> @@ -106,10 +106,8 @@ static int __init nf_debug_setup(char *arg)
>>> return 0;
>>>
>>> stderr_id = nf_get_id("NF_STDERR");
>>> - if (stderr_id) {
>>> - nf_console.flags |= CON_ENABLED;
>>> + if (stderr_id)
>>> register_console(&nf_console);
>>
>> My understanding is that this should enable the console
>> when debug=nfcon kernel parameter is used.
>>
>> It is a non-standard way. This is why CON_ENABLED flag
>> has to be explicitly set.
>
> Understood. I will add a comment explaining why CON_ENABLED is set here.
NatFeats is emulator feature. If you want to test the resulting kernel,
you can use either Aranym or Hatari emulator.
Aranym NF docs are here:
https://github.com/aranym/aranym/wiki/natfeats-proposal
Hatari m68k linux docs are here:
https://hatari.tuxfamily.org/doc/m68k-linux.txt
- Eero
next prev parent reply other threads:[~2022-11-10 17:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 14:15 [PATCH printk v3 00/40] reduce console_lock scope John Ogness
2022-11-07 14:16 ` [PATCH printk v3 24/40] tty: nfcon: use console_is_registered() John Ogness
2022-11-08 8:39 ` Geert Uytterhoeven
2022-11-10 13:58 ` Petr Mladek
2022-11-10 14:19 ` John Ogness
2022-11-10 17:50 ` Eero Tamminen [this message]
2022-11-11 14:43 ` [PATCH printk v3 00/40] reduce console_lock scope Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6deb895-342c-ca32-fa3c-39d6c826d70c@helsinkinet.fi \
--to=oak@helsinkinet.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).