[PATCH] bpf-helpers.7: wfix

[PATCH] bpf-helpers.7: wfix

[Thomas Piekarski]

Removing repeated word "will"

Signed-off-by: Thomas Piekarski <t.piekarski@deloquencia.de>

---
  man7/bpf-helpers.7 | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/man7/bpf-helpers.7 b/man7/bpf-helpers.7
index c8b3c7710..10ee24e5d 100644
--- a/man7/bpf-helpers.7
+++ b/man7/bpf-helpers.7
@@ -2338,7 +2338,7 @@ Look for an IPv6 socket.
  .UNINDENT
  .sp
  If the \fInetns\fP is a negative signed 32\-bit integer, then the
-socket lookup table in the netns associated with the \fIctx\fP will
+socket lookup table in the netns associated with the \fIctx\fP
  will be used. For the TC hooks, this is the netns of the device
  in the skb. For socket hooks, this is the netns of the socket.
  If \fInetns\fP is any other signed 32\-bit value greater than or
-- 
2.20.1

Re: [PATCH] bpf-helpers.7: wfix

[Michael Kerrisk (man-pages)]

On 8/19/20 5:18 PM, Thomas Piekarski wrote:
> Removing repeated word "will"
> 
> Signed-off-by: Thomas Piekarski <t.piekarski@deloquencia.de>

Hi Thomas,


This one is a little difficult, because the page is generated
from scripts. (It is pretty much unique in this respect in the
man-pages set.)

Looks like a patch is needed against the kernel source file
include/uapi/linux/bpf.h. Do you want to send a patch for that?[1]

Cheers,

Michael

[1] If yes, CC the people in commit f71c6143c2038df1cb43a4b9c90740d14f77467c
plus lkml I guess.


> ---
>   man7/bpf-helpers.7 | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/man7/bpf-helpers.7 b/man7/bpf-helpers.7
> index c8b3c7710..10ee24e5d 100644
> --- a/man7/bpf-helpers.7
> +++ b/man7/bpf-helpers.7
> @@ -2338,7 +2338,7 @@ Look for an IPv6 socket.
>   .UNINDENT
>   .sp
>   If the \fInetns\fP is a negative signed 32\-bit integer, then the
> -socket lookup table in the netns associated with the \fIctx\fP will
> +socket lookup table in the netns associated with the \fIctx\fP
>   will be used. For the TC hooks, this is the netns of the device
>   in the skb. For socket hooks, this is the netns of the socket.
>   If \fInetns\fP is any other signed 32\-bit value greater than or

Re: [PATCH] bpf-helpers.7: wfix

[Jakub Wilk]

* Michael Kerrisk (man-pages) <mtk.manpages@gmail.com>, 2020-08-22, 10:26:
>On 8/19/20 5:18 PM, Thomas Piekarski wrote:
>>Removing repeated word "will"
>>
>>Signed-off-by: Thomas Piekarski <t.piekarski@deloquencia.de>
>
>Hi Thomas,
>
>
>This one is a little difficult, because the page is generated from 
>scripts. (It is pretty much unique in this respect in the man-pages 
>set.)
>
>Looks like a patch is needed against the kernel source file 
>include/uapi/linux/bpf.h. Do you want to send a patch for that?

It's already fixed there:
https://git.kernel.org/linus/bfdfa51702dec67e9fcd52568b4cf3c7f799db8b

-- 
Jakub Wilk

Re: [PATCH] bpf-helpers.7: wfix

[Michael Kerrisk (man-pages)]

On Sat, 22 Aug 2020 at 10:42, Jakub Wilk <jwilk@jwilk.net> wrote:
>
> * Michael Kerrisk (man-pages) <mtk.manpages@gmail.com>, 2020-08-22, 10:26:
> >On 8/19/20 5:18 PM, Thomas Piekarski wrote:
> >>Removing repeated word "will"
> >>
> >>Signed-off-by: Thomas Piekarski <t.piekarski@deloquencia.de>
> >
> >Hi Thomas,
> >
> >
> >This one is a little difficult, because the page is generated from
> >scripts. (It is pretty much unique in this respect in the man-pages
> >set.)
> >
> >Looks like a patch is needed against the kernel source file
> >include/uapi/linux/bpf.h. Do you want to send a patch for that?
>
> It's already fixed there:
> https://git.kernel.org/linus/bfdfa51702dec67e9fcd52568b4cf3c7f799db8b

Thanks for checking that Jakub. I just regenerated the page from the
current kernel source.

Cheers,

Michael

-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

Re: [PATCH] bpf-helpers.7: wfix

[Thomas Piekarski]

On 22.08.20 10:42 AM, Jakub Wilk wrote:
> * Michael Kerrisk (man-pages) <mtk.manpages@gmail.com>, 2020-08-22, 10:26:
>> On 8/19/20 5:18 PM, Thomas Piekarski wrote:
>>> Removing repeated word "will"
>>>
>>> Signed-off-by: Thomas Piekarski <t.piekarski@deloquencia.de>
>>
>> This one is a little difficult, because the page is generated from 
>> scripts. (It is pretty much unique in this respect in the man-pages set.)
>>
>> Looks like a patch is needed against the kernel source file 
>> include/uapi/linux/bpf.h. Do you want to send a patch for that?
> 
> It's already fixed there:
> https://git.kernel.org/linus/bfdfa51702dec67e9fcd52568b4cf3c7f799db8b
> 

Hello Michael,
Hello Jakub,


interesting, I was not aware that bpf-helpers.7 is generated by 
bpf_helpers_doc.py.

Thanks for checking if it is fixed in the kernel sources.

Re: [PATCH] bpf-helpers.7: wfix

[Jakub Wilk]

* Michael Kerrisk <mtk.manpages@gmail.com>, 2020-08-22, 13:30:
>I just regenerated the page from the current kernel source.

The commit 7b203a3d6dc6c2b0 looks suspicious. It removes a large portion 
of text (65 insertions vs 432 deletions) and reintroduces a bug I fixed 
for Linux v5.7: https://git.kernel.org/linus/a33d3147945543f9

Did you accidentally resync the man page against an older Linux version?

-- 
Jakub Wilk

Re: [PATCH] bpf-helpers.7: wfix

[Michael Kerrisk (man-pages)]

Hi Jakub,

On Wed, 26 Aug 2020 at 19:41, Jakub Wilk <jwilk@jwilk.net> wrote:
>
> * Michael Kerrisk <mtk.manpages@gmail.com>, 2020-08-22, 13:30:
> >I just regenerated the page from the current kernel source.
>
> The commit 7b203a3d6dc6c2b0 looks suspicious. It removes a large portion
> of text (65 insertions vs 432 deletions) and reintroduces a bug I fixed
> for Linux v5.7: https://git.kernel.org/linus/a33d3147945543f9
>
> Did you accidentally resync the man page against an older Linux version?

It looks like you may be right, though I'm not sure how I managed to
do that. Anyway, I just resynced again, which added some 670 lines to
the page.

Thanks for spotting that.

Cheers,

Michael



-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/