linux-man.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Jakub Wilk <jwilk@jwilk.net>, Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org
Subject: Re: [PATCH] man3/*: srcfix: remove superfluous quotes around space-free arguments
Date: Mon, 6 Jul 2020 13:51:52 +0200	[thread overview]
Message-ID: <2492abac-ac1d-e017-f0dc-29468233fc1d@gmail.com> (raw)
In-Reply-To: <20200706043133.pznhl57cs5revfun@jwilk.net>

On 7/6/20 6:31 AM, Jakub Wilk wrote:
> THe strfmon(3) change is unrelated to the other changes, and should have 
> been in a separate patch.
> 
> * Bjarni Ingi Gislason <bjarniig@rhi.hi.is>, 2020-07-05, 13:40:
>> --- a/man3/strfmon.3
>> +++ b/man3/strfmon.3
>> @@ -29,10 +29,10 @@ strfmon, strfmon_l \- convert monetary value to a string
>> .B #include <monetary.h>
>> .PP
>> .BI "ssize_t strfmon(char *" s ", size_t " max ", const char *" format ,
>> -.B "...);"
>> +.IB  ... );
> 
> For variadic function the convention seems to be to format "..." in 
> bold; see scanf(3), printf(3), wprintf(3) and execv(3) man pages. This 
> makes sense, because unlike argument names, "..." appear literally in 
> the function prototypes.
> 
>> -.B const char *" format , "...);"
>> +.BI "const char *" format , ... );
> 
> Ditto. So this line should be:
> 
> .BI "const char *" format ", ...);"

Thanks, Jakub. Fixed.

Cheers,

Michael


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

      parent reply	other threads:[~2020-07-06 11:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-05 13:40 [PATCH] man3/*: srcfix: remove superfluous quotes around space-free arguments Bjarni Ingi Gislason
2020-07-06  4:31 ` Jakub Wilk
2020-07-06  9:20   ` Michael Kerrisk (man-pages)
2020-07-06 11:51   ` Michael Kerrisk (man-pages) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2492abac-ac1d-e017-f0dc-29468233fc1d@gmail.com \
    --to=mtk.manpages@gmail.com \
    --cc=bjarniig@rhi.hi.is \
    --cc=jwilk@jwilk.net \
    --cc=linux-man@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).