Re: [PATCH 0/4] landlock.7: Code example improvements

[Alejandro Colomar <alx.manpages@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1321 bytes --]

Hi Günther!

On 4/19/23 20:54, Günther Noack wrote:
> Various improvements as pointed out by Mickaël Salaün in
> https://lore.kernel.org/linux-man/5d90e3b0-1577-7efd-03b8-f94b6e50fbc1@digikod.net/
> 
> * Checking system call results differently, for consistency
> * Use constants for the compatibility table
>   (I'm not very attached to the other solution)
> * Better wording for error message if Landlock unusable
> * Return instead of exit() if Landlock unusable
> 
> Regarding the EOPNOTSUPP/ENOTSUP discussion, the consensus seems to be
> that EOPNOTSUPP is preferable, because that is the only of the two
> error codes that the kernel knows about.
> 
> Günther Noack (4):
>   landlock.7: Check syscall result with == -1 instead of <= 0
>   landlock.7: Use LANDLOCK_* constants for compatibility table
>   landlock.7: wfix: Error message wording in code example
>   landlock.7: Return instead of exit() if Landlock is unusable

Thanks!  Patch set applied.  (I tweaked the commit messages a little
bit.)

Cheers,
Alex

> 
>  man7/landlock.7 | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> 
> base-commit: 6693a21cf73c502f2429b4ec07698130a2be9a93

-- 
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]