Linux-man Archive on lore.kernel.org
 help / color / Atom feed
* [patch] setxattr.2: Add ERANGE to 'ERRORS' section
@ 2019-07-31 19:53 Finn O'Leary
  2019-08-01 17:40 ` Michael Kerrisk (man-pages)
  0 siblings, 1 reply; 2+ messages in thread
From: Finn O'Leary @ 2019-07-31 19:53 UTC (permalink / raw)
  To: mtk.manpages; +Cc: linux-man, linux-kernel

Hi,

Both the Ext2 filesystem handler and the Ext4 filesystem handler will
return the ERANGE error code. Ext2 will return it if the name or value 
is
too long to be able to be stored, Ext4 will return it if the name is too
long. For reference, the relevant files/lines (with excerpts) are:

fs/ext2/xattr.c: lines 394 to 396 in ext2_xattr_set
>  394         name_len = strlen(name);
>  395         if (name_len > 255 || value_len > sb->s_blocksize)
>  396                 return -ERANGE;

fs/ext4/xattr.c: lines 2317 to 2318 in ext4_xattr_set_handle
> 2317         if (strlen(name) > 255)
> 2318                 return -ERANGE;

Other filesystems also return this code:

xfs/libxfs/xfs_attr.h: lines 53 to 55
> * The maximum size (into the kernel or returned from the kernel) of an
> * attribute value or the buffer used for an attr_list() call.  Larger
> * sizes will result in an ERANGE return code.

It's possible that more filesystem handlers do this, a cursory grep 
shows
that most of the filesystem xattr handler files mention ERANGE in some
form. A suggested patch is below (I'm not 100% sure on the wording 
through).

Thanks

-- 
- Finn


diff --git a/man2/setxattr.2 b/man2/setxattr.2
index 66272ac..f8edad0 100644
--- a/man2/setxattr.2
+++ b/man2/setxattr.2
@@ -138,6 +138,13 @@ The namespace prefix of
  .I name
  is not valid.
  .TP
+.B ERANGE
+The given
+.I name
+or
+.I value
+is too long for the filesystem to store.
+.TP
  .B ENOTSUP
  Extended attributes are not supported by the filesystem, or are 
disabled,
  .TP

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch] setxattr.2: Add ERANGE to 'ERRORS' section
  2019-07-31 19:53 [patch] setxattr.2: Add ERANGE to 'ERRORS' section Finn O'Leary
@ 2019-08-01 17:40 ` Michael Kerrisk (man-pages)
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Kerrisk (man-pages) @ 2019-08-01 17:40 UTC (permalink / raw)
  To: Finn O'Leary; +Cc: mtk.manpages, linux-man, linux-kernel

Hello Finn,

On 7/31/19 9:53 PM, Finn O'Leary wrote:
> Hi,
> 
> Both the Ext2 filesystem handler and the Ext4 filesystem handler will
> return the ERANGE error code. Ext2 will return it if the name or value 
> is
> too long to be able to be stored, Ext4 will return it if the name is too
> long. For reference, the relevant files/lines (with excerpts) are:
> 
> fs/ext2/xattr.c: lines 394 to 396 in ext2_xattr_set
>>  394         name_len = strlen(name);
>>  395         if (name_len > 255 || value_len > sb->s_blocksize)
>>  396                 return -ERANGE;
> 
> fs/ext4/xattr.c: lines 2317 to 2318 in ext4_xattr_set_handle
>> 2317         if (strlen(name) > 255)
>> 2318                 return -ERANGE;
> 
> Other filesystems also return this code:
> 
> xfs/libxfs/xfs_attr.h: lines 53 to 55
>> * The maximum size (into the kernel or returned from the kernel) of an
>> * attribute value or the buffer used for an attr_list() call.  Larger
>> * sizes will result in an ERANGE return code.
> 
> It's possible that more filesystem handlers do this, a cursory grep 
> shows
> that most of the filesystem xattr handler files mention ERANGE in some
> form. A suggested patch is below (I'm not 100% sure on the wording 
> through).

Thanks. Patch applied, and I've done some rewording.

Cheers,

Michael



-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-31 19:53 [patch] setxattr.2: Add ERANGE to 'ERRORS' section Finn O'Leary
2019-08-01 17:40 ` Michael Kerrisk (man-pages)

Linux-man Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-man/0 linux-man/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-man linux-man/ https://lore.kernel.org/linux-man \
		linux-man@vger.kernel.org linux-man@archiver.kernel.org
	public-inbox-index linux-man


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-man


AGPL code for this site: git clone https://public-inbox.org/ public-inbox