* [PATCH -next] media: tegra: Make tegra210_video_formats static
@ 2020-05-11 11:20 Samuel Zou
2020-05-11 20:06 ` Sowjanya Komatineni
2020-05-12 20:55 ` Thierry Reding
0 siblings, 2 replies; 3+ messages in thread
From: Samuel Zou @ 2020-05-11 11:20 UTC (permalink / raw)
To: mchehab, gregkh, thierry.reding, jonathanh
Cc: skomatineni, linux-media, devel, linux-tegra, linux-kernel, Samuel Zou
Fix the following sparse warning:
drivers/staging/media/tegra-video/tegra210.c:589:33: warning: symbol 'tegra210_video_formats' was not declared.
The tegra210_video_formats has only call site within tegra210.c
It should be static
Fixes: 423d10a99b30 ("media: tegra: Add Tegra210 Video input driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Samuel Zou <zou_wei@huawei.com>
---
drivers/staging/media/tegra-video/tegra210.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/tegra-video/tegra210.c b/drivers/staging/media/tegra-video/tegra210.c
index 2045609..3baa4e3 100644
--- a/drivers/staging/media/tegra-video/tegra210.c
+++ b/drivers/staging/media/tegra-video/tegra210.c
@@ -586,7 +586,7 @@ enum tegra210_image_format {
}
/* Tegra210 supported video formats */
-const struct tegra_video_format tegra210_video_formats[] = {
+static const struct tegra_video_format tegra210_video_formats[] = {
/* RAW 8 */
TEGRA210_VIDEO_FMT(RAW8, 8, SRGGB8_1X8, 1, T_L8, SRGGB8),
TEGRA210_VIDEO_FMT(RAW8, 8, SGRBG8_1X8, 1, T_L8, SGRBG8),
--
2.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] media: tegra: Make tegra210_video_formats static
2020-05-11 11:20 [PATCH -next] media: tegra: Make tegra210_video_formats static Samuel Zou
@ 2020-05-11 20:06 ` Sowjanya Komatineni
2020-05-12 20:55 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Sowjanya Komatineni @ 2020-05-11 20:06 UTC (permalink / raw)
To: Samuel Zou, mchehab, gregkh, thierry.reding, jonathanh
Cc: linux-media, devel, linux-tegra, linux-kernel
On 5/11/20 4:20 AM, Samuel Zou wrote:
> Fix the following sparse warning:
>
> drivers/staging/media/tegra-video/tegra210.c:589:33: warning: symbol 'tegra210_video_formats' was not declared.
>
> The tegra210_video_formats has only call site within tegra210.c
> It should be static
>
> Fixes: 423d10a99b30 ("media: tegra: Add Tegra210 Video input driver")
> Reported-by: Hulk Robot<hulkci@huawei.com>
> Signed-off-by: Samuel Zou<zou_wei@huawei.com>
> ---
> drivers/staging/media/tegra-video/tegra210.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Sowjanya Komatineni <skomatineni@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] media: tegra: Make tegra210_video_formats static
2020-05-11 11:20 [PATCH -next] media: tegra: Make tegra210_video_formats static Samuel Zou
2020-05-11 20:06 ` Sowjanya Komatineni
@ 2020-05-12 20:55 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2020-05-12 20:55 UTC (permalink / raw)
To: Samuel Zou
Cc: mchehab, gregkh, jonathanh, skomatineni, linux-media, devel,
linux-tegra, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 629 bytes --]
On Mon, May 11, 2020 at 07:20:15PM +0800, Samuel Zou wrote:
> Fix the following sparse warning:
>
> drivers/staging/media/tegra-video/tegra210.c:589:33: warning: symbol 'tegra210_video_formats' was not declared.
>
> The tegra210_video_formats has only call site within tegra210.c
> It should be static
>
> Fixes: 423d10a99b30 ("media: tegra: Add Tegra210 Video input driver")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Samuel Zou <zou_wei@huawei.com>
> ---
> drivers/staging/media/tegra-video/tegra210.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-12 20:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-11 11:20 [PATCH -next] media: tegra: Make tegra210_video_formats static Samuel Zou
2020-05-11 20:06 ` Sowjanya Komatineni
2020-05-12 20:55 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).