From: Mauro Carvalho Chehab <mchehab@kernel.org>
To: unlisted-recipients:; (no To-header on input)
Cc: Duoming Zhou <duoming@zju.edu.cn>, Abylay Ospan <aospan@netup.ru>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sergey Kozlov <serjk@netup.ru>,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: [PATCH 03/24] media: netup_unidvb: fix use-after-free bug caused by del_timer()
Date: Sat, 13 May 2023 18:57:20 +0100 [thread overview]
Message-ID: <0d23dfd380ba4466d8e6208dcbf40a250a734099.1684000646.git.mchehab@kernel.org> (raw)
In-Reply-To: <53558de2b5c4f4ee6bfcfbe34e27071c2d0073d5.1684000646.git.mchehab@kernel.org>
From: Duoming Zhou <duoming@zju.edu.cn>
When Universal DVB card is detaching, netup_unidvb_dma_fini()
uses del_timer() to stop dma->timeout timer. But when timer
handler netup_unidvb_dma_timeout() is running, del_timer()
could not stop it. As a result, the use-after-free bug could
happen. The process is shown below:
(cleanup routine) | (timer routine)
| mod_timer(&dev->tx_sim_timer, ..)
netup_unidvb_finidev() | (wait a time)
netup_unidvb_dma_fini() | netup_unidvb_dma_timeout()
del_timer(&dma->timeout); |
| ndev->pci_dev->dev //USE
Fix by changing del_timer() to del_timer_sync().
Link: https://lore.kernel.org/linux-media/20230308125514.4208-1-duoming@zju.edu.cn
Fixes: 52b1eaf4c59a ("[media] netup_unidvb: NetUP Universal DVB-S/S2/T/T2/C PCI-E card driver")
Signed-off-by: Duoming Zhou <duoming@zju.edu.cn>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
drivers/media/pci/netup_unidvb/netup_unidvb_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/netup_unidvb/netup_unidvb_core.c b/drivers/media/pci/netup_unidvb/netup_unidvb_core.c
index 8287851b5ffd..aaa1d2dedebd 100644
--- a/drivers/media/pci/netup_unidvb/netup_unidvb_core.c
+++ b/drivers/media/pci/netup_unidvb/netup_unidvb_core.c
@@ -697,7 +697,7 @@ static void netup_unidvb_dma_fini(struct netup_unidvb_dev *ndev, int num)
netup_unidvb_dma_enable(dma, 0);
msleep(50);
cancel_work_sync(&dma->work);
- del_timer(&dma->timeout);
+ del_timer_sync(&dma->timeout);
}
static int netup_unidvb_dma_setup(struct netup_unidvb_dev *ndev)
--
2.40.1
next prev parent reply other threads:[~2023-05-13 17:57 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-13 17:57 [PATCH 01/24] media: pvrusb2: fix DVB_CORE dependency Mauro Carvalho Chehab
2023-05-13 17:57 ` [PATCH 02/24] media: dvb_demux: fix a bug for the continuity counter Mauro Carvalho Chehab
2023-05-13 17:57 ` Mauro Carvalho Chehab [this message]
2023-05-13 17:57 ` [PATCH 04/24] media: dvb-usb: az6027: fix three null-ptr-deref in az6027_i2c_xfer() Mauro Carvalho Chehab
2023-05-17 5:06 ` zzam
2023-05-13 17:57 ` [PATCH 05/24] media: dvb-usb-v2: ec168: fix null-ptr-deref in ec168_i2c_xfer() Mauro Carvalho Chehab
2023-05-17 5:10 ` zzam
2023-05-19 9:17 ` Wei Chen
2023-06-02 6:41 ` zzam
2023-05-13 17:57 ` [PATCH 06/24] media: dvb-usb-v2: ce6230: fix null-ptr-deref in ce6230_i2c_master_xfer() Mauro Carvalho Chehab
2023-05-13 17:57 ` [PATCH 07/24] media: dvb-usb-v2: rtl28xxu: fix null-ptr-deref in rtl28xxu_i2c_xfer Mauro Carvalho Chehab
2023-05-17 6:55 ` zzam
2023-05-13 17:57 ` [PATCH 08/24] media: dvb-usb: digitv: fix null-ptr-deref in digitv_i2c_xfer() Mauro Carvalho Chehab
2023-05-13 17:57 ` [PATCH 09/24] media: dvb-usb: dw2102: fix uninit-value in su3000_read_mac_address Mauro Carvalho Chehab
2023-05-13 17:57 ` [PATCH 10/24] media: netup_unidvb: fix irq init by register it at the end of probe Mauro Carvalho Chehab
2023-05-13 17:57 ` [PATCH 11/24] media: dvb_ca_en50221: fix a size write bug Mauro Carvalho Chehab
2023-05-13 17:57 ` [PATCH 12/24] media: ttusb-dec: fix memory leak in ttusb_dec_exit_dvb() Mauro Carvalho Chehab
2023-05-13 17:57 ` [PATCH 13/24] media: mn88443x: fix !CONFIG_OF error by drop of_match_ptr from ID table Mauro Carvalho Chehab
2023-05-13 17:57 ` [PATCH 14/24] media: dvb-core: Fix use-after-free due to race condition occurring in dvb_frontend Mauro Carvalho Chehab
2023-05-13 17:57 ` [PATCH 15/24] media: dvb-core: Fix use-after-free due to race condition occurring in dvb_net Mauro Carvalho Chehab
2023-05-13 17:57 ` [PATCH 16/24] media: dvb-core: Fix use-after-free due to race condition occurring in dvb_register_device() Mauro Carvalho Chehab
2023-05-13 17:57 ` [PATCH 17/24] media: dvb-core: Fix kernel WARNING for blocking operation in wait_event*() Mauro Carvalho Chehab
2023-05-13 17:57 ` [PATCH 18/24] media: dvbdev: fix most coding style issues Mauro Carvalho Chehab
2023-05-13 17:57 ` [PATCH 19/24] media: dvbdev.h: do some kernel-doc cleanups Mauro Carvalho Chehab
2023-05-13 17:57 ` [PATCH 20/24] media: c8sectpfe: dvb: remove unnecessary (void*) conversions Mauro Carvalho Chehab
2023-05-13 17:57 ` [PATCH 21/24] media: dvb-usb: " Mauro Carvalho Chehab
2023-05-13 17:57 ` [PATCH 22/24] media: dw2102: return -EIO instead of -1 for mac address read errors Mauro Carvalho Chehab
2023-05-13 17:57 ` [PATCH 23/24] media: dvb: add missing DVB-S2X FEC parameter values Mauro Carvalho Chehab
2023-05-13 17:57 ` [PATCH 24/24] media: dvb: bump DVB API version Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d23dfd380ba4466d8e6208dcbf40a250a734099.1684000646.git.mchehab@kernel.org \
--to=mchehab@kernel.org \
--cc=aospan@netup.ru \
--cc=duoming@zju.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=serjk@netup.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).