linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@kernel.org>
To: unlisted-recipients:; (no To-header on input)
Cc: YongSu Yoo <yongsuyoo0215@gmail.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: [PATCH 02/24] media: dvb_demux: fix a bug for the continuity counter
Date: Sat, 13 May 2023 18:57:19 +0100	[thread overview]
Message-ID: <7efb10d8dc70ea3000cc70dca53407c52488acd1.1684000646.git.mchehab@kernel.org> (raw)
In-Reply-To: <53558de2b5c4f4ee6bfcfbe34e27071c2d0073d5.1684000646.git.mchehab@kernel.org>

From: YongSu Yoo <yongsuyoo0215@gmail.com>

In dvb_demux.c, some logics exist which compare the expected
continuity counter and the real continuity counter. If they
are not matched each other, both of the expected continuity
counter and the real continuity counter should be printed.
But there exists a bug that the expected continuity counter
is not correctly printed. The expected continuity counter is
replaced with the real countinuity counter + 1 so that
the epected continuity counter is not correclty printed.
This is wrong. This bug is fixed.

Link: https://lore.kernel.org/linux-media/20230305212519.499-1-yongsuyoo0215@gmail.com

Signed-off-by: YongSu Yoo <yongsuyoo0215@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
 drivers/media/dvb-core/dvb_demux.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/dvb-core/dvb_demux.c b/drivers/media/dvb-core/dvb_demux.c
index 398c86279b5b..7c4d86bfdd6c 100644
--- a/drivers/media/dvb-core/dvb_demux.c
+++ b/drivers/media/dvb-core/dvb_demux.c
@@ -115,12 +115,12 @@ static inline int dvb_dmx_swfilter_payload(struct dvb_demux_feed *feed,
 
 	cc = buf[3] & 0x0f;
 	ccok = ((feed->cc + 1) & 0x0f) == cc;
-	feed->cc = cc;
 	if (!ccok) {
 		set_buf_flags(feed, DMX_BUFFER_FLAG_DISCONTINUITY_DETECTED);
 		dprintk_sect_loss("missed packet: %d instead of %d!\n",
 				  cc, (feed->cc + 1) & 0x0f);
 	}
+	feed->cc = cc;
 
 	if (buf[1] & 0x40)	// PUSI ?
 		feed->peslen = 0xfffa;
@@ -300,7 +300,6 @@ static int dvb_dmx_swfilter_section_packet(struct dvb_demux_feed *feed,
 
 	cc = buf[3] & 0x0f;
 	ccok = ((feed->cc + 1) & 0x0f) == cc;
-	feed->cc = cc;
 
 	if (buf[3] & 0x20) {
 		/* adaption field present, check for discontinuity_indicator */
@@ -336,6 +335,7 @@ static int dvb_dmx_swfilter_section_packet(struct dvb_demux_feed *feed,
 		feed->pusi_seen = false;
 		dvb_dmx_swfilter_section_new(feed);
 	}
+	feed->cc = cc;
 
 	if (buf[1] & 0x40) {
 		/* PUSI=1 (is set), section boundary is here */
-- 
2.40.1


  reply	other threads:[~2023-05-13 17:58 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-13 17:57 [PATCH 01/24] media: pvrusb2: fix DVB_CORE dependency Mauro Carvalho Chehab
2023-05-13 17:57 ` Mauro Carvalho Chehab [this message]
2023-05-13 17:57 ` [PATCH 03/24] media: netup_unidvb: fix use-after-free bug caused by del_timer() Mauro Carvalho Chehab
2023-05-13 17:57 ` [PATCH 04/24] media: dvb-usb: az6027: fix three null-ptr-deref in az6027_i2c_xfer() Mauro Carvalho Chehab
2023-05-17  5:06   ` zzam
2023-05-13 17:57 ` [PATCH 05/24] media: dvb-usb-v2: ec168: fix null-ptr-deref in ec168_i2c_xfer() Mauro Carvalho Chehab
2023-05-17  5:10   ` zzam
2023-05-19  9:17     ` Wei Chen
2023-06-02  6:41       ` zzam
2023-05-13 17:57 ` [PATCH 06/24] media: dvb-usb-v2: ce6230: fix null-ptr-deref in ce6230_i2c_master_xfer() Mauro Carvalho Chehab
2023-05-13 17:57 ` [PATCH 07/24] media: dvb-usb-v2: rtl28xxu: fix null-ptr-deref in rtl28xxu_i2c_xfer Mauro Carvalho Chehab
2023-05-17  6:55   ` zzam
2023-05-13 17:57 ` [PATCH 08/24] media: dvb-usb: digitv: fix null-ptr-deref in digitv_i2c_xfer() Mauro Carvalho Chehab
2023-05-13 17:57 ` [PATCH 09/24] media: dvb-usb: dw2102: fix uninit-value in su3000_read_mac_address Mauro Carvalho Chehab
2023-05-13 17:57 ` [PATCH 10/24] media: netup_unidvb: fix irq init by register it at the end of probe Mauro Carvalho Chehab
2023-05-13 17:57 ` [PATCH 11/24] media: dvb_ca_en50221: fix a size write bug Mauro Carvalho Chehab
2023-05-13 17:57 ` [PATCH 12/24] media: ttusb-dec: fix memory leak in ttusb_dec_exit_dvb() Mauro Carvalho Chehab
2023-05-13 17:57 ` [PATCH 13/24] media: mn88443x: fix !CONFIG_OF error by drop of_match_ptr from ID table Mauro Carvalho Chehab
2023-05-13 17:57 ` [PATCH 14/24] media: dvb-core: Fix use-after-free due to race condition occurring in dvb_frontend Mauro Carvalho Chehab
2023-05-13 17:57 ` [PATCH 15/24] media: dvb-core: Fix use-after-free due to race condition occurring in dvb_net Mauro Carvalho Chehab
2023-05-13 17:57 ` [PATCH 16/24] media: dvb-core: Fix use-after-free due to race condition occurring in dvb_register_device() Mauro Carvalho Chehab
2023-05-13 17:57 ` [PATCH 17/24] media: dvb-core: Fix kernel WARNING for blocking operation in wait_event*() Mauro Carvalho Chehab
2023-05-13 17:57 ` [PATCH 18/24] media: dvbdev: fix most coding style issues Mauro Carvalho Chehab
2023-05-13 17:57 ` [PATCH 19/24] media: dvbdev.h: do some kernel-doc cleanups Mauro Carvalho Chehab
2023-05-13 17:57 ` [PATCH 20/24] media: c8sectpfe: dvb: remove unnecessary (void*) conversions Mauro Carvalho Chehab
2023-05-13 17:57 ` [PATCH 21/24] media: dvb-usb: " Mauro Carvalho Chehab
2023-05-13 17:57 ` [PATCH 22/24] media: dw2102: return -EIO instead of -1 for mac address read errors Mauro Carvalho Chehab
2023-05-13 17:57 ` [PATCH 23/24] media: dvb: add missing DVB-S2X FEC parameter values Mauro Carvalho Chehab
2023-05-13 17:57 ` [PATCH 24/24] media: dvb: bump DVB API version Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7efb10d8dc70ea3000cc70dca53407c52488acd1.1684000646.git.mchehab@kernel.org \
    --to=mchehab@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=yongsuyoo0215@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).