From: Tomasz Stanislawski <t.stanislaws@samsung.com>
To: linux-media@vger.kernel.org
Cc: m.szyprowski@samsung.com, t.stanislaws@samsung.com,
kyungmin.park@samsung.com, hverkuil@xs4all.nl,
laurent.pinchart@ideasonboard.com
Subject: [PATCH 5/8] v4l: fix v4l_fill_dv_preset_info function
Date: Wed, 29 Jun 2011 14:51:14 +0200 [thread overview]
Message-ID: <1309351877-32444-6-git-send-email-t.stanislaws@samsung.com> (raw)
In-Reply-To: <1309351877-32444-1-git-send-email-t.stanislaws@samsung.com>
The function fills struct v4l2_dv_enum_preset with appropriate
preset parameters but it forgets to zero field named reserved.
This patch fixes this bug.
Signed-off-by: Tomasz Stanislawski <t.stanislaws@samsung.com>
---
drivers/media/video/v4l2-common.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/media/video/v4l2-common.c b/drivers/media/video/v4l2-common.c
index 003e648..e7c02e9 100644
--- a/drivers/media/video/v4l2-common.c
+++ b/drivers/media/video/v4l2-common.c
@@ -592,6 +592,8 @@ int v4l_fill_dv_preset_info(u32 preset, struct v4l2_dv_enum_preset *info)
info->width = dv_presets[preset].width;
info->height = dv_presets[preset].height;
strlcpy(info->name, dv_presets[preset].name, sizeof(info->name));
+ /* assure that reserved fields are zeroed */
+ memset(info->reserved, 0, sizeof(info->reserved));
return 0;
}
EXPORT_SYMBOL_GPL(v4l_fill_dv_preset_info);
--
1.7.5.4
next prev parent reply other threads:[~2011-06-29 12:52 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-29 12:51 [PATCH v6 0/8] TV drivers for Samsung S5P platform (media part) Tomasz Stanislawski
2011-06-29 12:51 ` [PATCH 1/8] v4l: add macro for 1080p59_54 preset Tomasz Stanislawski
2011-07-04 16:09 ` [RFC] DV timings spec fixes at V4L2 API - was: " Mauro Carvalho Chehab
2011-07-04 22:47 ` Laurent Pinchart
2011-07-04 23:28 ` Mauro Carvalho Chehab
2011-07-05 6:46 ` Hans Verkuil
2011-07-05 7:26 ` Hans Verkuil
2011-07-05 12:08 ` Mauro Carvalho Chehab
2011-07-05 13:20 ` Hans Verkuil
2011-07-05 19:02 ` Andy Walls
2011-07-05 23:25 ` Mauro Carvalho Chehab
2011-07-06 1:05 ` Andy Walls
2011-07-06 11:04 ` Mauro Carvalho Chehab
2011-07-06 11:31 ` Hans Verkuil
2011-07-06 11:48 ` Mauro Carvalho Chehab
2011-07-06 12:03 ` Laurent Pinchart
2011-07-06 12:09 ` Mauro Carvalho Chehab
2011-07-06 12:13 ` Laurent Pinchart
2011-07-06 12:20 ` Mauro Carvalho Chehab
2011-07-06 12:14 ` Hans Verkuil
2011-07-06 12:31 ` Mauro Carvalho Chehab
2011-07-06 12:56 ` Hans Verkuil
2011-07-06 14:10 ` Mauro Carvalho Chehab
2011-07-06 19:39 ` Mauro Carvalho Chehab
2011-07-07 11:33 ` Hans Verkuil
2011-07-07 13:52 ` Mauro Carvalho Chehab
2011-07-07 14:58 ` Hans Verkuil
2011-07-07 16:18 ` Mauro Carvalho Chehab
2011-07-07 17:52 ` Tomasz Stanislawski
2011-06-29 12:51 ` [PATCH 2/8] v4l: add g_tvnorms_output callback to V4L2 subdev Tomasz Stanislawski
2011-06-29 12:51 ` [PATCH 3/8] v4l: add g_dv_preset " Tomasz Stanislawski
2011-06-29 12:51 ` [PATCH 4/8] v4l: add g_std_output " Tomasz Stanislawski
2011-06-29 12:51 ` Tomasz Stanislawski [this message]
2011-07-14 16:02 ` [PATCH 5/8] v4l: fix v4l_fill_dv_preset_info function Mauro Carvalho Chehab
2011-06-29 12:51 ` [PATCH 6/8] v4l: s5p-tv: add drivers for HDMI on Samsung S5P platform Tomasz Stanislawski
2011-06-29 12:51 ` [PATCH 7/8] v4l: s5p-tv: add SDO driver for " Tomasz Stanislawski
2011-06-29 12:51 ` [PATCH 8/8] v4l: s5p-tv: add TV Mixer " Tomasz Stanislawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309351877-32444-6-git-send-email-t.stanislaws@samsung.com \
--to=t.stanislaws@samsung.com \
--cc=hverkuil@xs4all.nl \
--cc=kyungmin.park@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).